fix: op consumption check should happen in CastingVM instead of PatternIota#1035
Open
pythonmcpi wants to merge 1 commit intoFallingColors:mainfrom
Open
fix: op consumption check should happen in CastingVM instead of PatternIota#1035pythonmcpi wants to merge 1 commit intoFallingColors:mainfrom
pythonmcpi wants to merge 1 commit intoFallingColors:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the op limit check happens in
PatternIota.executerather than inCastingVM. This means that executable non-pattern iota and certain continuation frames can go past the op limit, and in extreme cases, hang the server thread indefinitely. (The latter case is currently possible with addons, and the most natural fix is moving the check toCastingVM.)This PR moves the op limit check to the same place the stack limit is checked. Player-observable behavior should remain the same.