feat: x25519 tag and mlkem768x25519 tagpq support#707
Open
dlubawy wants to merge 4 commits intoFiloSottile:mainfrom
Open
feat: x25519 tag and mlkem768x25519 tagpq support#707dlubawy wants to merge 4 commits intoFiloSottile:mainfrom
dlubawy wants to merge 4 commits intoFiloSottile:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR would add a new x25519 tag and mlkem768x25519 tagpq recipient to
age-plugin-tagandage-plugin-tagpq. I felt the original tagged recipient spec should have included x25519 based keys as well so that users could convert their original age keys to any type of hardware key they desired. I've also been working on a branch of the age-plugin-yubikey repo which adds support for these key types too, and have been using this code here as a test for that. Having an officially supported reference spec would be great so that I actually know my code there is aligning well with age as a whole.Not sure if this is desirable since it does add more complication to age which is supposed to be very simple, but I figure it's worth a discussion especially since it's mostly extending the already existing age keys.