CPP-2814 feat: add serverless authentication using serverless assume role #1210
CPP-2814 feat: add serverless authentication using serverless assume role #1210zeinaaabbb merged 1 commit intomainfrom
Conversation
| - name: 'teardown-review' | ||
| steps: | ||
| pre: | ||
| - serverless-assume-role |
There was a problem hiding this comment.
question: Have we tested or used this step anywhere? The docs seem to suggest that the orb exports a setup job that should be used along with a custom executor
There was a problem hiding this comment.
@olusoladavid, I was tryining to replicate what we have done in here in cloudsmith yaml file?
| - name: 'teardown-review' | ||
| steps: | ||
| pre: | ||
| - serverless-assume-role |
There was a problem hiding this comment.
issue: ah I was wrong actually this command comes from the Tool Kit orb instead of the serverless-framework orb (so we don't need to import the latter orb in the end.) you can access it be using the Tool Kit orb's name as a prefix, like this
| - serverless-assume-role | |
| - tool-kit/serverless-assume-role |
additionally, the command takes two arguments which need to be passed to it for it to work. they can be passed similar to how they are passed to the deploy-* jobs, like this (note you don't need the !toolkit/if-defined line because this is the serverless plugin so those options are always required)
bac84c1 to
15c40dd
Compare
ivomurrell
left a comment
There was a problem hiding this comment.
thank you! fingers crossed this will fix it 🤞🤞
| steps: | ||
| pre: | ||
| - tool-kit/serverless-assume-role: | ||
| aws-account-id: '@dotcom-tool-kit/serverless.awsAccountId' |
There was a problem hiding this comment.
issue: these need to use the !tool-kit/option syntax like in the circleci-deploy example
Description
This PR adds serverless authentication for the teardown steps in the
pr-closeworkflow.Previously, the teardown step would fail due to a lack of authentication. This introduces
serverless-assume-rolesteps, similar to how we already handle with Hako appsChecklist:
feat(circleci): add support for nightly workflows,fix: set Heroku app name for staging apps too