chore: bump action runtime to Node 24 (fixes #448)#450
chore: bump action runtime to Node 24 (fixes #448)#450jhuleatt merged 1 commit intoFirebaseExtended:mainfrom
Conversation
Resolves FirebaseExtended#448. GitHub is forcing all Node 20 JavaScript actions onto Node 24 on June 2nd 2026 and surfacing a deprecation annotation on every run in the meantime. Bumping `runs.using` from `node20` to `node24` in action.yml silences the warning and gets ahead of the forced cutover. Scope is deliberately minimal: - Only `action.yml` changes. - `npm run build` reruns cleanly and produces a byte-identical `bin/action.min.js` (the runtime declaration does not affect the microbundle output target, which is already `--target node`). - `npm run format:check` clean. `npm run test` — 13 passed, 0 failed. - No source, dependency, or API changes. Only the action runtime is touched; consumers do not need to update their workflows.
There was a problem hiding this comment.
Code Review
This pull request updates the GitHub Action runtime from Node 20 to Node 24. Feedback suggests aligning the development environment, specifically the TypeScript configuration and package dependencies, with the new Node 24 target to ensure consistency across environments.
| color: "blue" | ||
| runs: | ||
| using: "node20" | ||
| using: "node24" |
There was a problem hiding this comment.
While bumping the runtime to Node 24 addresses the deprecation warning, the project's development configuration remains significantly outdated. Specifically, package.json still references @tsconfig/node12 and older versions of development dependencies. To ensure consistent behavior between development, testing, and production environments, and to leverage modern Node.js features or optimizations, it is recommended to update the TypeScript configuration and development environment to align with the Node 24 target.
|
Thank you @MukundaKatta! |
Summary
Fixes #448.
GitHub will force all Node-20 JavaScript actions onto Node 24 on June 2nd 2026 and surfaces a deprecation annotation on every run in the meantime. Every `action-hosting-deploy` invocation today emits:
This PR bumps `runs.using` from `node20` → `node24` in `action.yml` so the warning goes away and we're on the other side of the forced cutover. That's the only line that changes.
Scope (deliberately minimal)
Verification
```
$ npm run format:check
(clean)
$ npm run build
Build "firebase-hosting-preview-action" to bin:
177 kB: action.min.js.gz
126 kB: action.min.js.br
$ git diff --stat -- "*.min.js"
(empty)
$ npm run test
Test Suites: 3 passed, 3 total
Tests: 13 passed, 13 total
```
Notes for the reviewer
Checklist