fix(hover): correct element identity and path expansion for hover sel… - #57
Open
heipa24 wants to merge 2 commits into
Open
fix(hover): correct element identity and path expansion for hover sel…#57heipa24 wants to merge 2 commits into
heipa24 wants to merge 2 commits into
Conversation
heipa24
commented
Aug 14, 2026
- Compare RuntimeId byte-wise as authoritative identity in IsSameElement, falling back to FlaUI Equals plus name/type/location matching when both RuntimeIds are missing (Flutter/self-drawn apps)
- Expand full parent chain with the RawView walker to select the hovered element instead of adding an orphan top-level node; insert missing intermediate nodes via InsertMissingElement
- Guard circular detection with IsSameElementSafe (RuntimeId required) and a maxPathDepth=100 safety limit
- ScrollIntoView and focus the tree so programmatic selection shows the active blue highlight
- Guard string.Format in InternalLogger against FormatException on user data
…ection - Compare RuntimeId byte-wise as authoritative identity in IsSameElement, falling back to FlaUI Equals plus name/type/location matching when both RuntimeIds are missing (Flutter/self-drawn apps) - Expand full parent chain with the RawView walker to select the hovered element instead of adding an orphan top-level node; insert missing intermediate nodes via InsertMissingElement - Guard circular detection with IsSameElementSafe (RuntimeId required) and a maxPathDepth=100 safety limit - ScrollIntoView and focus the tree so programmatic selection shows the active blue highlight - Guard string.Format in InternalLogger against FormatException on user data
Author
|
To avoid the performance cost of updating the element tree and details panel on every hover move, consider updating on demand instead: reuse the existing "Get Current Element State" button (or add a dedicated button/hotkey) to sync the hovered element into the tree and details once, which keeps the hover loop lightweight. A "live update" toggle could preserve the current behavior for cases where continuous updates are wanted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.