Skip to content

feat: Move to Role from ClusterRole #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hardillb wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat: Move to Role from ClusterRole #913

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
87679f1
Move to Role from ClusterRole
hardillb May 22, 2026
d6b29c4
rename RoleBinding to allow modification of reference
hardillb May 22, 2026
eb7e208
Merge branch 'main' into remove-cluster-rollbinding
hardillb May 26, 2026
67cdbbe
Apply suggestions from code review
hardillb May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions helm/flowfuse/templates/service-account.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,11 @@ metadata:
{{- end }}

---

apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
kind: Role
metadata:
name: {{ ((.Values.forge).clusterRole).name | default "create-pod" }}
Copy link
Copy Markdown
Contributor

@ppawlowski ppawlowski May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will still use forge.clusterRole to define the Role name. Changing this will introduce a braking change. I think we should at least mention in the Readme that this will affect Role resource creation, not ClusterRole.

namespace: {{ .Values.forge.projectNamespace | default "flowforge" }}
labels:
{{- include "forge.labels" . | nindent 4 }}
rules:
Expand All @@ -45,7 +45,7 @@ rules:
resources: ["deployments", "deployment/status"]
verbs: ["create", "patch", "get", "list", "update", "watch", "delete"]
- apiGroups: [""]
resources: ["persistentvolumes", "persistentvolumeclaims"]
resources: ["persistentvolumeclaims"]
verbs: ["create", "patch", "get", "list", "watch", "delete"]
- apiGroups: [""]
resources: ["services"]
Expand All @@ -63,15 +63,15 @@ rules:
apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
metadata:
name: {{ ((.Values.forge).clusterRole).name | default "create-pod" }}
namespace: {{ .Values.forge.projectNamespace }}
name: {{ ((.Values.forge).clusterRole).name | default "create-pod" }}-limited
namespace: {{ .Values.forge.projectNamespace | default "flowforge" }}
labels:
{{- include "forge.labels" . | nindent 4 }}
subjects:
- kind: ServiceAccount
name: flowforge
namespace: {{ .Release.Namespace }}
roleRef:
Copy link
Copy Markdown
Contributor

@ppawlowski ppawlowski May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrading helm release with a custom clusterRole.name defined causes upgrade failure, see https://github.com/FlowFuse/flowfuse/actions/runs/26503988570/job/78052046575#step:15:41

kind: ClusterRole
kind: Role
name: {{ ((.Values.forge).clusterRole).name | default "create-pod" }}
apiGroup: rbac.authorization.k8s.io
Loading