Skip to content

refactor: use lombok extension mechanism #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paodb merged 1 commit into from
Nov 17, 2025
Merged

refactor: use lombok extension mechanism #125

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/main/java/com/flowingcode/vaadin/addons/demo/MultiSourceCodeViewer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@
import java.util.List;
import java.util.Map;
import java.util.Optional;
import lombok.experimental.ExtensionMethod;

@ExtensionMethod(value = JsonMigration.class, suppressBaseMethods = true)
public class MultiSourceCodeViewer extends Div {

private static final String DATA_URL = "source-url";
Expand All @@ -47,7 +49,7 @@ public MultiSourceCodeViewer(List<SourceCodeTab> sourceCodeTabs, Map<String, Str
selectedTab = tabs.getSelectedTab();

getElement().addEventListener("fragment-request", ev -> {
JsonValue filename = JsonMigration.getEventData(ev).get("event.detail.filename");
JsonValue filename = ev.getEventData().get("event.detail.filename");
findTabWithFilename(Optional.ofNullable(filename).map(JsonValue::asString).orElse(null))
.ifPresent(tab -> {
tabs.setSelectedTab(tab);
Expand Down
4 changes: 3 additions & 1 deletion src/main/java/com/flowingcode/vaadin/addons/demo/SourceCodeViewer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,11 @@
import elemental.json.Json;
import elemental.json.JsonObject;
import java.util.Map;
import lombok.experimental.ExtensionMethod;

@SuppressWarnings("serial")
@JsModule("./code-viewer.ts")
@ExtensionMethod(value = JsonMigration.class, suppressBaseMethods = true)
public class SourceCodeViewer extends Div implements HasSize {

private final Element codeViewer;
Expand Down Expand Up @@ -86,7 +88,7 @@ private void setProperties(Map<String, String> properties) {
env.put(k, Json.create(v));
}
});
JsonMigration.setPropertyJson(codeViewer, "env", env);
codeViewer.setPropertyJson("env", env);
}
}

Expand Down