test: fix column toggle test for Vaadin 25

[javier-godoy]

Close #159

Summary by CodeRabbit

• Chores
  • Updated test infrastructure dependencies and enhanced version detection capabilities for integration tests
  • Updated copyright notices

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Dependency update for testbench-rpc (1.4.0 → 1.5.0) alongside version-aware logic implementation in GridHelperElement to support Vaadin 25. New Version API added to IntegrationView and related interfaces, with copyright year updates throughout.

Changes

Cohort / File(s)	Summary
Dependency updates pom.xml	Updated com.flowingcode.vaadin.test:testbench-rpc from 1.4.0 to 1.5.0
Version-aware test infrastructure src/test/java/com/flowingcode/vaadin/addons/gridhelpers/it/GridHelperElement.java	Added version-aware logic for column toggle element queries; version >= 25 switches to vaadin-menu-bar with theme=gridHelperToggle filter, while earlier versions use legacy overlay-based queries. Introduced private version field, private constructor accepting Version, and public withVersion() fluent method.
Version API and interface updates src/test/java/com/flowingcode/vaadin/addons/gridhelpers/it/IntegrationView.java, src/test/java/com/flowingcode/vaadin/addons/gridhelpers/it/IntegrationViewCallables.java	Added getVersion() method returning Version object to support version detection in integration tests. Updated imports and interface signatures.
Copyright year and API chaining updates src/test/java/com/flowingcode/vaadin/addons/gridhelpers/it/ColumnToggleIT.java, src/test/java/com/flowingcode/vaadin/addons/gridhelpers/it/IntegrationViewCallables.java	Updated copyright years to 2026 (and 2022–2026 for IntegrationViewCallables). Modified GridHelperElement initialization in ColumnToggleIT to use fluent API with .withVersion() chaining.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• feat: add compatibility with Vaadin 25 #144: Modifies GridHelperElement for Vaadin 25 compatibility, introducing version-aware element selection logic similar to this PR's approach.
• test: make tests compatible with Vaadin 25 #160: Updates test suite for Vaadin 25 compatibility by upgrading testbench-rpc dependency and introducing version-aware test code changes.

Suggested reviewers

• paodb
• mlopezFC

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: fixing the column toggle test for Vaadin 25 compatibility, which directly aligns with the PR's objective to fix failing ColumnToggle integration tests on Vaadin 25.
Linked Issues check	✅ Passed	The PR implements version-aware column toggle element detection to resolve Selenium timeouts in ColumnToggle IT tests on Vaadin 25 [#159], fulfilling the primary objective to make getColumnToggleElements compatible with Vaadin 25.
Out of Scope Changes check	✅ Passed	The PR includes copyright year updates and a minor dependency version bump (testbench-rpc 1.4.0→1.5.0) alongside the core Vaadin 25 compatibility fixes, which are supporting changes aligned with the main objective.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In @pom.xml:
- Around line 129-133: The pom declares dependency
com.flowingcode.vaadin.test:testbench-rpc with version 1.5.0 which does not
exist on Maven Central and will break the build; update the version to an
existing release (e.g., 1.4.0) or change to the correct private/internal
coordinates if 1.5.0 is intended, by editing the dependency entry for groupId
"com.flowingcode.vaadin.test" and artifactId "testbench-rpc" in the pom to a
resolvable version.

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3a97b64 and 6117169.

📒 Files selected for processing (5)

• pom.xml
• src/test/java/com/flowingcode/vaadin/addons/gridhelpers/it/ColumnToggleIT.java
• src/test/java/com/flowingcode/vaadin/addons/gridhelpers/it/GridHelperElement.java
• src/test/java/com/flowingcode/vaadin/addons/gridhelpers/it/IntegrationView.java
• src/test/java/com/flowingcode/vaadin/addons/gridhelpers/it/IntegrationViewCallables.java

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: build-vaadin24
• GitHub Check: build-vaadin25

🔇 Additional comments (5)

src/test/java/com/flowingcode/vaadin/addons/gridhelpers/it/IntegrationView.java (1)

86-89: LGTM - Version API implementation is clean and correct.

The getVersion() method properly implements the interface contract and provides the runtime version information needed for version-aware test behavior.

src/test/java/com/flowingcode/vaadin/addons/gridhelpers/it/IntegrationViewCallables.java (1)

29-30: LGTM - Interface method declaration is well-placed.

The getVersion() method is appropriately added to the RMI callable interface, enabling test code to retrieve the server-side Vaadin version.

src/test/java/com/flowingcode/vaadin/addons/gridhelpers/it/GridHelperElement.java (2)

41-55: LGTM - Fluent versioning API with proper state management.

The private constructor and withVersion() method follow a clean immutable pattern for creating versioned instances. The @NonNull annotation on withVersion() appropriately prevents accidental null versions.

---

79-96: Good fix - Version-aware query addresses the Vaadin 25 timeout issue.

The version-conditional logic correctly switches the element query strategy for Vaadin 25+, where the column toggle uses a vaadin-menu-bar with a gridHelperToggle theme instead of overlay elements. This should resolve the waitForFirst timeouts reported in issue #159.

Note: When version is null, the code defaults to the pre-25 behavior. This is acceptable since ColumnToggleIT.setup() always calls withVersion(), but other callers should be aware of this fallback.

src/test/java/com/flowingcode/vaadin/addons/gridhelpers/it/ColumnToggleIT.java (1)

44-46: LGTM - Test setup correctly integrates version-aware behavior.

The setup now retrieves the Vaadin version from the server and passes it to GridHelperElement, ensuring the correct DOM query strategy is used based on the runtime environment. This completes the fix for the Vaadin 25 compatibility issue.