Fix RA unit test endpoint initialization size - #1352
Merged
rawalexe merged 1 commit intoJul 8, 2026
Conversation
Member
|
Good catch, thank you for the contribution. |
Use the NetworkEndPoint_t size when clearing the xEndPoint test fixture in the RA unit test. Generated-by: OpenAI Codex Signed-off-by: aineoae86-sys <ai.neo.ae86@gmail.com>
rawalexe
force-pushed
the
codex/fix-ra-endpoint-memset-size
branch
from
July 8, 2026 17:17
d62e42a to
2eb3bf9
Compare
kstribrnAmzn
approved these changes
Jul 8, 2026
allanli4
approved these changes
Jul 8, 2026
rawalexe
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
test_vReceiveRA_ValidICMPPrefix_IncorrectOptiondeclaresxEndPointasNetworkEndPoint_t, but clears it withsizeof( NetworkInterface_t ).This updates the fixture initialization to use
sizeof( NetworkEndPoint_t ), matching the declared object and the surrounding RA unit tests.Test Steps
xEndPointmemset size intest/unit-test/FreeRTOS_RA/FreeRTOS_RA_utest.c.git diff --check -- test/unit-test/FreeRTOS_RA/FreeRTOS_RA_utest.c.git ls-files --eol test/unit-test/FreeRTOS_RA/FreeRTOS_RA_utest.c.I could not run the CMake/Ninja unit test locally because this Windows environment does not have
cmake,ninja,make,gcc,clang,ruby, orbundleinstalled.Duplicate check:
FreeRTOS_RA_utest.NetworkEndPoint_tmemset size issue.Checklist:
Related Issue
N/A
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.