Unittest: Fix and forbid "control reaches end of non-void function" - #1356
Open
anordal wants to merge 1 commit into
Open
Unittest: Fix and forbid "control reaches end of non-void function"#1356anordal wants to merge 1 commit into
anordal wants to merge 1 commit into
Conversation
This is a continuation of FreeRTOS#1228 (fix and forbid specific warnings). This commit fixes or removes all non-void functions that did not return a value. I don't know why Ubsan hasn't catched these yet. Indeed, most of them were unused. All of them were stubs. Another warning down, and with it 500 LOC. There were only two places I had to choose between returning success or failure: Only in the FreeRTOS_Sockets unittest did it matter to the outcome of the test. In the other, in FreeRTOS_RA, the caller ignored the return value.
anordal
force-pushed
the
unittest-fix-control-reaches-end-of-nonvoid-function
branch
from
July 11, 2026 08:53
904dd41 to
c137ea2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes or removes all non-void functions that did not return a value. I don't know why Ubsan hasn't catched these yet.
Indeed, most of them were unused. All of them were stubs. Another warning down, and with it 500 LOC.
There were only two places I had to choose between returning success or failure: Only in the FreeRTOS_Sockets unittest did it matter to the outcome of the test. In the other, in FreeRTOS_RA, the caller ignored the return value.
Checklist:
Related Issue
This is a continuation of #1228 (fix and forbid specific warnings).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.