Final changes for glvis-4.3

[tzanio]

📆 Target release date: July 15, 2024 August 7, 2024

🟡 In Progress:

• Update website: Website changes for glvis-4.3 web#12

🟢 DONE:

• Finalize and merge this PR into master
• add test and baseline for quadrature data visualization ← @najlkin, @tzanio
• Update CHANGELOG ← @tzanio
• Fixed use-after-delete with dynamic streams and switching quadratures #302
• Higher auto-refinement limits #285 (Vote: auto-refinement limits #292)
• Fixed dynamic loading of parallel quadratures #301
• Fix an issue when numlock is on #300
• retroactive styling for #288 #299
• [BUG] Fixed init of the main thread #298
• update copyright 2022 -> 2024 #297
• Number formatting #288 (see Change colorbar number format #260)
• Visualization of quadrature functions #286
• Update version number from 4.2 to 4.3
• Vector field options in 2D with single colored arrows above #278 ← @v-dobrev will review
• Switch from <key>A</key> to A in README.md? See this issue
• Support for integral finite elements #280

⚪ After the release:

• Update pyglvis (Merge Anywidget pyglvis#44)
• Update glvis-js and glvis.org/live
• CI misc improvements #296
• Update CI to test installation with both GNU make and CMake #241
• Add style check to PR CIs

⚫ Postponed:

• Color palettes #289 (see Additional color palettes? #268)
• ND_R2D visualization with glvis fails #291
• Updating GLVis mesh vector or scalar solution without drawing a new mesh #272
• Calling VisualizationSceneSolution3d from own application #274
• Configurable line width with modern OpenGL #232
• Refactoring to remove global state #170
• [WIP] Improved transparency with dual depth peeling #166
• Future Improvements 🚀 #133
• Support for visualization of particle data
• Adaptive geometry refiner
• Raytracing?!
• Better vector graphics output
• Improved testing with random keys

[acfisher]

LGTM

[najlkin]

What is the idea with quadrature functions? Interpreting them as L2 elements would be very simple 😉 . I have done that in the past in my codes.

[tzanio]

What is the idea with quadrature functions? Interpreting them as L2 elements would be very simple 😉 . I have done that in the past in my codes.

This has been discussed multiple times, but there are essentially 3 options we have considered:

1. Plot p.w. const function on the LOR Gauss-Lobatto mesh, where each LOR element contains exactly one Gauss-Legendre quadrature point. (The p points of 1D GLL quadrature rule are interleaved by the p+1 points of the 1D GL rule)

2. Interpret quadrature values as the dofs of an L2 grid funcion

3. Draw a little sphere for each point

Option 3 is most general and will be required for "Support for visualization of particle data". I personally like option 1, because it does not introduce variations beyond the original data. That works only on quad/hex meshes though.

[najlkin]

I see, we must reach consensus then what way to go, which might take longer than actually implementing it 😁 .

[tzanio]

We can also support both options 😁

[najlkin]

I found out there is no smooth vizualization in 2D for vector fields atm. This could be also added, but it would require to differentiate the vector-to-scalar function 🤔

[justinlaughlin]

In the future should PRs be pulled into glvis-4.x-dev first instead of master?

[tzanio]

In the future should PRs be pulled into glvis-4.x-dev first instead of master?

No, the current policy is that PRs should go first in master and then we merge master in glvis-4.3-dev.

(The intention for the release branches was to be small and short-lived)

[tzanio]

MFEM autotest was giving styling errors, so I run "make style" here but the results may not be fully satisfactory.

Please review c697e0b

[najlkin]

We should really add make style to PR CIs as #288 was merged without it 🙃

[justinlaughlin]

We should really add make style to PR CIs as #288 was merged without it 🙃

Oops, my bad 😅

[tzanio]

Should we add a test stream for quadrature function visualization?

For example quadrature.saved.zip corresponding to GLVis/web#12 (comment)?

[najlkin]

Should we add a test stream for quadrature function visualization?

That would be wise 😉 , but we do not have a matching example code for that, but I do not know if it is really a rule to have one... 🤔

[tzanio]

we do not have a matching example code for that, but I do not know if it is really a rule to have one... 🤔

it is not a hard requirement

[najlkin]

Everything looks good, the quadrature test would be nice if it is added, but it goes to data anyway.

[tzanio]

the quadrature test would be nice if it is added, but it goes to data anyway.

I don't think it hurts to do it now. I can propose a PR with the above file, unless you prefer something else @najlkin

[najlkin]

the quadrature test would be nice if it is added, but it goes to data anyway.

I don't think it hurts to do it now. I can propose a PR with the above file, unless you prefer something else @najlkin

No, let us do it 🚀 .

[justinlaughlin]

While we have all this glvis momentum can we get eyes on GLVis/pyglvis#44 so we can merge :). This can be after the glvis release of course. There will be other changes needed for pyglvis (such as updating the glvis-js version hosted on npm), but it will be nice to test with the rewrite.