Skip to content

feat(ui): animate attachment picker + close on back press#2588

Open
Brazol wants to merge 2 commits intofeat/design-refreshfrom
feat/animate-attachment-picker
Open

feat(ui): animate attachment picker + close on back press#2588
Brazol wants to merge 2 commits intofeat/design-refreshfrom
feat/animate-attachment-picker

Conversation

@Brazol
Copy link
Copy Markdown
Contributor

@Brazol Brazol commented Apr 1, 2026

Submit a pull request

Linear: FLU-430. FLU-414

Github Issue: #

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

Screenshots / Videos

animate.mov

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 1, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 67fcad38-0fc2-430d-9c9e-c12213b6b463

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/animate-attachment-picker

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

❌ Patch coverage is 67.56757% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.31%. Comparing base (cd3cd88) to head (87248b9).

Files with missing lines Patch % Lines
...er/lib/src/message_input/stream_message_input.dart 67.56% 12 Missing ⚠️
Additional details and impacted files
@@                   Coverage Diff                   @@
##           feat/design-refresh    #2588      +/-   ##
=======================================================
- Coverage                65.32%   65.31%   -0.01%     
=======================================================
  Files                      429      429              
  Lines                    26137    26141       +4     
=======================================================
+ Hits                     17073    17075       +2     
- Misses                    9064     9066       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Brazol Brazol changed the title feat(ui): animate attachment picker feat(ui): animate attachment picker + close on back press Apr 1, 2026
Copy link
Copy Markdown
Contributor

@renefloor renefloor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When opening the attachment picker the animation is a bit weird. The bottom padding (safe area I guess) is removed first.

Original recording:
https://github.com/user-attachments/assets/acb226b2-7571-4758-9c3d-452de7e1a999

Slow-mo of the recording:
https://github.com/user-attachments/assets/b57297b2-fa09-42a3-ae1d-9ef63338d027

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants