feat(ui): animate attachment picker + close on back press#2588
feat(ui): animate attachment picker + close on back press#2588Brazol wants to merge 2 commits intofeat/design-refreshfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/design-refresh #2588 +/- ##
=======================================================
- Coverage 65.32% 65.31% -0.01%
=======================================================
Files 429 429
Lines 26137 26141 +4
=======================================================
+ Hits 17073 17075 +2
- Misses 9064 9066 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
renefloor
left a comment
There was a problem hiding this comment.
When opening the attachment picker the animation is a bit weird. The bottom padding (safe area I guess) is removed first.
Original recording:
https://github.com/user-attachments/assets/acb226b2-7571-4758-9c3d-452de7e1a999
Slow-mo of the recording:
https://github.com/user-attachments/assets/b57297b2-fa09-42a3-ae1d-9ef63338d027
Submit a pull request
Linear: FLU-430. FLU-414
Github Issue: #
CLA
Description of the pull request
Screenshots / Videos
animate.mov