Skip to content

fix(ui): hide mark as unread for own messages#2590

Open
Brazol wants to merge 2 commits intofeat/design-refreshfrom
feat/hide-mark-as-unread
Open

fix(ui): hide mark as unread for own messages#2590
Brazol wants to merge 2 commits intofeat/design-refreshfrom
feat/hide-mark-as-unread

Conversation

@Brazol
Copy link
Copy Markdown
Contributor

@Brazol Brazol commented Apr 1, 2026

Submit a pull request

Linear: FLU-463

in-depth Slack thread

CLA

  • I have signed the Stream CLA (required).
  • The code changes follow best practices
  • Code changes are tested (add some information if not applicable)

Description of the pull request

Screenshots / Videos

Before After
img img

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 1, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2e748cca-d003-4031-8e3a-6a61b0366f7a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/hide-mark-as-unread

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.32%. Comparing base (cd3cd88) to head (7b43b53).
⚠️ Report is 6 commits behind head on feat/design-refresh.

Additional details and impacted files
@@                 Coverage Diff                  @@
##           feat/design-refresh    #2590   +/-   ##
====================================================
  Coverage                65.32%   65.32%           
====================================================
  Files                      429      428    -1     
  Lines                    26137    26137           
====================================================
+ Hits                     17073    17075    +2     
+ Misses                    9064     9062    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment on lines 160 to 166
// If message is a parent message, it can be marked unread independent of
// other logic.
if (isParentMessage) {
messageActions.add(markUnreadAction());
}
// If the message is in the channel view, only other user messages can be
// marked unread.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update the inline doc now that we no longer check for currentUser in this if block. and also same for the parent message.

Copy link
Copy Markdown
Member

@xsahil03x xsahil03x left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants