-
Notifications
You must be signed in to change notification settings - Fork 179
feat(nhi): add secret is_vaulted info in ggshield output #1095
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4942d03 to
9a38e5d
Compare
xblanchot-gg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks good to me, thanks !
sevbch
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Did you look into adding this to the sarif output? For reference we had this MR 8ac31b6 recently which interacted with it.
|
You can update py-gitguardian version in the pyproject.toml, we'll update the version once py-gitguardian is released :) |
0898cc2 to
dc1be89
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1095 +/- ##
=======================================
Coverage 91.89% 91.89%
=======================================
Files 144 144
Lines 6081 6086 +5
=======================================
+ Hits 5588 5593 +5
Misses 493 493
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
agateau-gg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! My only request would be to add the field you added in the JSON output to https://github.com/GitGuardian/ggshield/blob/main/doc/schemas/secret.json.
dc1be89 to
a655688
Compare
Use the newly introduced
is_vaultedfield to modify text and json outputs of ggshield.Works in staging (see the new
Secret in Secrets Managerline):With this invalid, dummy secret: