Skip to content

Conversation

@amascia-gg
Copy link
Contributor

@amascia-gg amascia-gg commented May 7, 2025

⚠️ Needs a py-gitguardan release before merge ⚠️

Use the newly introduced is_vaulted field to modify text and json outputs of ggshield.
Works in staging (see the new Secret in Secrets Manager line):

Screenshot 2025-05-07 at 14 31 01

With this invalid, dummy secret:

Screenshot 2025-05-07 at 14 31 57

@amascia-gg amascia-gg requested a review from a team as a code owner May 7, 2025 12:46
@amascia-gg amascia-gg force-pushed the amascia/nhi-651/add-nhi-option branch from 4942d03 to 9a38e5d Compare May 7, 2025 13:07
Copy link
Contributor

@xblanchot-gg xblanchot-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me, thanks !

Copy link
Collaborator

@sevbch sevbch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Did you look into adding this to the sarif output? For reference we had this MR 8ac31b6 recently which interacted with it.

@salome-voltz
Copy link
Contributor

You can update py-gitguardian version in the pyproject.toml, we'll update the version once py-gitguardian is released :)
see this MR for reference

@amascia-gg amascia-gg force-pushed the amascia/nhi-651/add-nhi-option branch 3 times, most recently from 0898cc2 to dc1be89 Compare May 14, 2025 12:26
@amascia-gg amascia-gg requested a review from sevbch May 14, 2025 12:35
@codecov
Copy link

codecov bot commented May 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.89%. Comparing base (d518ac6) to head (a655688).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1095   +/-   ##
=======================================
  Coverage   91.89%   91.89%           
=======================================
  Files         144      144           
  Lines        6081     6086    +5     
=======================================
+ Hits         5588     5593    +5     
  Misses        493      493           
Flag Coverage Δ
unittests 91.89% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@agateau-gg agateau-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! My only request would be to add the field you added in the JSON output to https://github.com/GitGuardian/ggshield/blob/main/doc/schemas/secret.json.

@amascia-gg amascia-gg force-pushed the amascia/nhi-651/add-nhi-option branch from dc1be89 to a655688 Compare May 15, 2025 11:56
@amascia-gg amascia-gg requested a review from agateau-gg May 15, 2025 12:47
@agateau-gg agateau-gg merged commit 277c995 into main May 15, 2025
52 of 53 checks passed
@agateau-gg agateau-gg deleted the amascia/nhi-651/add-nhi-option branch May 15, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants