Skip to content

Conversation

@sevbch
Copy link
Collaborator

@sevbch sevbch commented Jun 23, 2025

Context

CI is failing on clearlinux tests because libstdcpp is not installed in the docker image for clearlinux. This is most likely new and coming from the latest version of the docker image but we can't know for sure as the image isn't versioned.

What has been done

  • install libstdcpp lib for clearlinux
  • cosmetic changes: move all git installs in the new requirements step

Validation

CI failed before, succeeds after.

PR check list

  • As much as possible, the changes include tests (unit and/or functional)
  • If the changes affect the end user (new feature, behavior change, bug fix) then the PR has a changelog entry (see doc/dev/getting-started.md). If the changes do not affect the end user, then the skip-changelog label has been added to the PR.

@codecov
Copy link

codecov bot commented Jun 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.91%. Comparing base (f78efe7) to head (1f87a61).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1106   +/-   ##
=======================================
  Coverage   91.91%   91.91%           
=======================================
  Files         144      144           
  Lines        6094     6094           
=======================================
  Hits         5601     5601           
  Misses        493      493           
Flag Coverage Δ
unittests 91.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@agateau-gg agateau-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a request for comment :)

@sevbch sevbch marked this pull request as ready for review June 23, 2025 13:47
@sevbch sevbch requested a review from a team as a code owner June 23, 2025 13:47
@sevbch sevbch enabled auto-merge June 23, 2025 14:06
@sevbch sevbch merged commit bc4777c into main Jun 23, 2025
27 checks passed
@sevbch sevbch deleted the fix/clearlinux branch June 23, 2025 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants