Skip to content

fix: the GHE script does not generate an image anymore #1156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
agateau-gg wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: the GHE script does not generate an image anymore #1156

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions scripts/create-ghe-environment
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,12 +97,12 @@ archive_path="$PWD/$image_name.tar.gz"

log_progress "Building custom image, based on $distrib"
# Sanity check
if ! grep -q -- "-slim as build\$" "$ROOT_DIR/Dockerfile" ; then
if ! grep -q -- "-slim AS build\$" "$ROOT_DIR/Dockerfile" ; then
die "Dockerfile has changed, this script is outdated"
fi

# Modify the FROM command to use the distribution we want
sed "s/-slim as build\$/-slim-$distrib as build/" "$ROOT_DIR/Dockerfile" \
sed "s/-slim AS build\$/-slim-$distrib AS build/" "$ROOT_DIR/Dockerfile" \
| docker build --tag "$image_name" --file - "$ROOT_DIR"

log_progress "Building container from image"
Expand Down
Loading