Skip to content

Remove additional network settings from slurm A3U,A4,A4X VM examples#5740

Merged
agrawalkhushi18 merged 5 commits into
GoogleCloudPlatform:developfrom
agrawalkhushi18:vms-additional-net
Jun 9, 2026
Merged

Remove additional network settings from slurm A3U,A4,A4X VM examples#5740
agrawalkhushi18 merged 5 commits into
GoogleCloudPlatform:developfrom
agrawalkhushi18:vms-additional-net

Conversation

@agrawalkhushi18

@agrawalkhushi18 agrawalkhushi18 commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

This PR eliminates additional network configuration in the slurm A3U, A4 and A4X VM examples. This is a follow up item referencing PR#5652

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

  • Fork your PR branch from the Toolkit "develop" branch (not main)
  • Test all changes with pre-commit in a local branch #
  • Confirm that "make tests" passes all tests
  • Add or modify unit tests to cover code changes
  • Ensure that unit test coverage remains above 80%
  • Update all applicable documentation
  • Follow Cluster Toolkit Contribution guidelines #

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the network interface configuration for several machine learning VM examples. By shifting from explicitly defined network structures to using 'instance_additional_networks' references, the configuration becomes more concise and easier to manage while maintaining the required network connectivity.

Highlights

  • Network Configuration Simplification: Replaced hardcoded network interface definitions with references to 'instance_additional_networks' for A3U, A4, and A4X VM examples.
  • Reduced Redundancy: Removed verbose network interface boilerplate in favor of modular network definitions, improving maintainability across VM example configurations.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request simplifies the network interface configuration in several machine learning VM blueprints (a3ultra-vm.yaml, a4high-vm.yaml, and a4x-vm.yaml) by replacing verbose inline network definitions with references to instance_additional_networks from the respective network modules. There are no review comments, and I have no feedback to provide.

@agrawalkhushi18 agrawalkhushi18 added the release-improvements Added to release notes under the "Improvements" heading. label Jun 4, 2026
@agrawalkhushi18 agrawalkhushi18 marked this pull request as ready for review June 8, 2026 05:25
@agrawalkhushi18 agrawalkhushi18 requested a review from a team as a code owner June 8, 2026 05:25
Comment thread examples/machine-learning/a3-ultragpu-8g/a3ultra-vm.yaml Outdated
@agrawalkhushi18 agrawalkhushi18 requested a review from arpit974 June 8, 2026 07:47

@SwarnaBharathiMantena SwarnaBharathiMantena left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agrawalkhushi18 agrawalkhushi18 merged commit ad831f5 into GoogleCloudPlatform:develop Jun 9, 2026
12 of 81 checks passed
mikhailpovolotskiy pushed a commit to mikhailpovolotskiy/cluster-toolkit that referenced this pull request Jun 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-improvements Added to release notes under the "Improvements" heading.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants