[Beta] Add Terraform autogen support and acceptance tests for Agent Identity#18174
[Beta] Add Terraform autogen support and acceptance tests for Agent Identity#18174shekhar-433 wants to merge 1 commit into
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
cb86938 to
cf5f280
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit cb86938: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_agent_identity_auth_provider" "primary" {
allowed_scopes = # value needed
auth_provider_type_params {
three_legged_oauth {
authorization_url = # value needed
client_id = # value needed
client_secret = # value needed
default_continue_uri = # value needed
enable_pkce = # value needed
token_url = # value needed
}
two_legged_oauth {
client_id = # value needed
client_secret = # value needed
token_url = # value needed
}
}
blocked_scopes = # value needed
labels = # value needed
workload_ids = # value needed
}
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. 🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @shekhar-433, @slevenick VCR tests complete for cb86938! |
cf5f280 to
a7d7291
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit cf5f280: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_agent_identity_auth_provider" "primary" {
allowed_scopes = # value needed
auth_provider_type_params {
three_legged_oauth {
authorization_url = # value needed
client_id = # value needed
client_secret = # value needed
default_continue_uri = # value needed
enable_pkce = # value needed
token_url = # value needed
}
two_legged_oauth {
client_id = # value needed
client_secret = # value needed
token_url = # value needed
}
}
blocked_scopes = # value needed
labels = # value needed
workload_ids = # value needed
}
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @shekhar-433, @slevenick VCR tests complete for cf5f280! |
a7d7291 to
0199cbb
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit a7d7291: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_agent_identity_auth_provider" "primary" {
allowed_scopes = # value needed
auth_provider_type_params {
three_legged_oauth {
authorization_url = # value needed
client_id = # value needed
client_secret = # value needed
default_continue_uri = # value needed
enable_pkce = # value needed
token_url = # value needed
}
two_legged_oauth {
client_id = # value needed
client_secret = # value needed
token_url = # value needed
}
}
blocked_scopes = # value needed
labels = # value needed
workload_ids = # value needed
}
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @shekhar-433, @slevenick VCR tests complete for a7d7291! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 0199cbb: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_agent_identity_auth_provider" "primary" {
auth_provider_type_params {
three_legged_oauth {
authorization_url = # value needed
client_id = # value needed
client_secret = # value needed
default_continue_uri = # value needed
enable_pkce = # value needed
token_url = # value needed
}
}
labels = # value needed
}
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. 🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @shekhar-433, @slevenick VCR tests complete for 0199cbb! |
7ecf6a3 to
18e14ad
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 7ecf6a3: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_agent_identity_auth_provider" "primary" {
labels = # value needed
}
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 14 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @shekhar-433, @slevenick VCR tests complete for 7ecf6a3! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 18e14ad: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_agent_identity_auth_provider" "primary" {
labels = # value needed
}
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @shekhar-433, @slevenick VCR tests complete for 18e14ad! |
18e14ad to
b5d3692
Compare
b5d3692 to
fbe9218
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b5d3692: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_agent_identity_auth_provider" "primary" {
labels = # value needed
}
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @shekhar-433, @slevenick VCR tests complete for b5d3692! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit fbe9218: Diff reportYour PR generated the following diffs in downstream repositories:
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @shekhar-433, @slevenick VCR tests complete for fbe9218! |
|
Hi @slevenick |
|
/gcbrun |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit fbe9218: Diff reportYour PR generated the following diffs in downstream repositories:
Missing service labelsThe following new resources do not have corresponding service labels:
If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels. Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @shekhar-433, @slevenick VCR tests complete for fbe9218! |
|
Please do a local review with a Google engineer from the service team as described at go/terraform-service-review. Let me know when that's finished and I'll follow up with final review & merge. |
Sure, Thanks. |
|
Hi @Anurag168 |
This CL adds the google_workload_identity_service_agent resource to the Terraform provider via mmv1.
The implementation includes:
Product Definition: Defines the core API infrastructure and routing for the Google Cloud Agent Identity service (agentidentity.googleapis.com)
Resource Schema: Defines the complete Terraform HCL schema mapping and CRUD behaviors for the google_agent_identity_auth_provider resource (projects/{project}/locations/{location}/authProviders/{authProviderId}).
Key Implementation Details:
go/terraform-autogen) and onboarded to both GA and Beta providers.sensitive: truefor secret tokens (apiKeyandclientSecret).ignore_read: trueon input-only attributes (workload_idsand secret blocks) to prevent diffs.deleted: true) cleanly via custom decoder andpost_readtemplates.post_create,post_update, andpost_deletesleep delays to allow Identity Storage Service (ISS) database replication to settle.TestAccAgentIdentityAuthProvider_basicand_update).Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.