Skip to content

[Beta] Add Terraform autogen support and acceptance tests for Agent Identity#18174

Open
shekhar-433 wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
shekhar-433:add-agentidentity-terraform
Open

[Beta] Add Terraform autogen support and acceptance tests for Agent Identity#18174
shekhar-433 wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
shekhar-433:add-agentidentity-terraform

Conversation

@shekhar-433

@shekhar-433 shekhar-433 commented Jul 4, 2026

Copy link
Copy Markdown

This CL adds the google_workload_identity_service_agent resource to the Terraform provider via mmv1.

The implementation includes:

  • Product Definition: Defines the core API infrastructure and routing for the Google Cloud Agent Identity service (agentidentity.googleapis.com)

  • Resource Schema: Defines the complete Terraform HCL schema mapping and CRUD behaviors for the google_agent_identity_auth_provider resource (projects/{project}/locations/{location}/authProviders/{authProviderId}).

    Key Implementation Details:

    • Developed through the autogen toolchain (go/terraform-autogen) and onboarded to both GA and Beta providers.
    • Configures sensitive: true for secret tokens (apiKey and clientSecret).
    • Configures ignore_read: true on input-only attributes (workload_ids and secret blocks) to prevent diffs.
    • Handles backend soft-deletion (deleted: true) cleanly via custom decoder and post_read templates.
    • Includes custom post_create, post_update, and post_delete sleep delays to allow Identity Storage Service (ISS) database replication to settle.
    • Includes full, verified acceptance test suites covering Create, Read, Update/PATCH, and Delete (TestAccAgentIdentityAuthProvider_basic and _update).

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_agent_identity_auth_provider`

@github-actions github-actions Bot requested a review from slevenick July 4, 2026 23:09
@github-actions

github-actions Bot commented Jul 4, 2026

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@shekhar-433 shekhar-433 force-pushed the add-agentidentity-terraform branch from cb86938 to cf5f280 Compare July 4, 2026 23:12
@modular-magician

modular-magician commented Jul 4, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit cb86938:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 13 files changed, 1828 insertions(+)
google-beta provider View Diff 11 files changed, 1818 insertions(+)
terraform-google-conversion View Diff 3 files changed, 427 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_agent_identity_auth_provider (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_agent_identity_auth_provider" "primary" {
  allowed_scopes = # value needed
  auth_provider_type_params {
    three_legged_oauth {
      authorization_url    = # value needed
      client_id            = # value needed
      client_secret        = # value needed
      default_continue_uri = # value needed
      enable_pkce          = # value needed
      token_url            = # value needed
    }
    two_legged_oauth {
      client_id     = # value needed
      client_secret = # value needed
      token_url     = # value needed
    }
  }
  blocked_scopes = # value needed
  labels         = # value needed
  workload_ids   = # value needed
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_agent_identity_auth_provider

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
6692 5993 688 11
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccAgentIdentityAuthProvider_basic
  • TestAccAgentIdentityAuthProvider_update
  • TestAccComputeFirewallPolicyAssociation_organization
  • TestAccContainerCluster_regionalWithNodePool
  • TestAccContainerNodePool_withHostMaintenancePolicy
  • TestAccDataformConfig_update
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccProjectIamMemberRemove_memberInMultipleBindings
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccComputeFirewallPolicyAssociation_organization
✅ Log ❌ Error · Log TestAccProjectIamMemberRemove_memberInMultipleBindings
❌ Error · Log - TestAccAgentIdentityAuthProvider_basic
❌ Error · Log - TestAccAgentIdentityAuthProvider_update
❌ Error · Log - TestAccContainerCluster_regionalWithNodePool
❌ Error · Log - TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log - TestAccDataformConfig_update
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@shekhar-433, @slevenick VCR tests complete for cb86938!

@shekhar-433 shekhar-433 force-pushed the add-agentidentity-terraform branch from cf5f280 to a7d7291 Compare July 4, 2026 23:20
@modular-magician

modular-magician commented Jul 4, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit cf5f280:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 13 files changed, 1828 insertions(+)
google-beta provider View Diff 11 files changed, 1818 insertions(+)
terraform-google-conversion View Diff 3 files changed, 427 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_agent_identity_auth_provider (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_agent_identity_auth_provider" "primary" {
  allowed_scopes = # value needed
  auth_provider_type_params {
    three_legged_oauth {
      authorization_url    = # value needed
      client_id            = # value needed
      client_secret        = # value needed
      default_continue_uri = # value needed
      enable_pkce          = # value needed
      token_url            = # value needed
    }
    two_legged_oauth {
      client_id     = # value needed
      client_secret = # value needed
      token_url     = # value needed
    }
  }
  blocked_scopes = # value needed
  labels         = # value needed
  workload_ids   = # value needed
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_agent_identity_auth_provider

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
6692 5996 688 8
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccAgentIdentityAuthProvider_basic
  • TestAccAgentIdentityAuthProvider_update
  • TestAccContainerCluster_regionalWithNodePool
  • TestAccContainerNodePool_withHostMaintenancePolicy
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccAgentIdentityAuthProvider_basic
❌ Error · Log - TestAccAgentIdentityAuthProvider_update
❌ Error · Log - TestAccContainerCluster_regionalWithNodePool
❌ Error · Log - TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@shekhar-433, @slevenick VCR tests complete for cf5f280!

@shekhar-433 shekhar-433 force-pushed the add-agentidentity-terraform branch from a7d7291 to 0199cbb Compare July 4, 2026 23:29
@modular-magician

modular-magician commented Jul 4, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit a7d7291:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 13 files changed, 1828 insertions(+)
google-beta provider View Diff 11 files changed, 1818 insertions(+)
terraform-google-conversion View Diff 3 files changed, 427 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_agent_identity_auth_provider (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_agent_identity_auth_provider" "primary" {
  allowed_scopes = # value needed
  auth_provider_type_params {
    three_legged_oauth {
      authorization_url    = # value needed
      client_id            = # value needed
      client_secret        = # value needed
      default_continue_uri = # value needed
      enable_pkce          = # value needed
      token_url            = # value needed
    }
    two_legged_oauth {
      client_id     = # value needed
      client_secret = # value needed
      token_url     = # value needed
    }
  }
  blocked_scopes = # value needed
  labels         = # value needed
  workload_ids   = # value needed
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_agent_identity_auth_provider

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
6692 5996 688 8
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccAgentIdentityAuthProvider_basic
  • TestAccAgentIdentityAuthProvider_update
  • TestAccContainerCluster_regionalWithNodePool
  • TestAccContainerNodePool_withHostMaintenancePolicy
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccAgentIdentityAuthProvider_basic
❌ Error · Log - TestAccAgentIdentityAuthProvider_update
❌ Error · Log - TestAccContainerCluster_regionalWithNodePool
❌ Error · Log - TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@shekhar-433, @slevenick VCR tests complete for a7d7291!

@modular-magician

modular-magician commented Jul 4, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 0199cbb:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 13 files changed, 1872 insertions(+)
google-beta provider View Diff 11 files changed, 1862 insertions(+)
terraform-google-conversion View Diff 3 files changed, 427 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_agent_identity_auth_provider (4 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_agent_identity_auth_provider" "primary" {
  auth_provider_type_params {
    three_legged_oauth {
      authorization_url    = # value needed
      client_id            = # value needed
      client_secret        = # value needed
      default_continue_uri = # value needed
      enable_pkce          = # value needed
      token_url            = # value needed
    }
  }
  labels = # value needed
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_agent_identity_auth_provider

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
6693 5994 688 11
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccAgentIdentityAuthProvider_basic
  • TestAccAgentIdentityAuthProvider_full
  • TestAccAgentIdentityAuthProvider_update
  • TestAccContainerCluster_regionalWithNodePool
  • TestAccContainerNodePool_withHostMaintenancePolicy
  • TestAccDataformConfig_update
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccProjectIamMemberRemove_memberInMultipleBindings
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccDataformConfig_update
✅ Log ❌ Error · Log TestAccProjectIamMemberRemove_memberInMultipleBindings
❌ Error · Log - TestAccAgentIdentityAuthProvider_basic
❌ Error · Log - TestAccAgentIdentityAuthProvider_full
❌ Error · Log - TestAccAgentIdentityAuthProvider_update
❌ Error · Log - TestAccContainerCluster_regionalWithNodePool
❌ Error · Log - TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

🔴 Replaying Rerun Failed: Some tests failed due to non-determinism when VCR replayed the response. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@shekhar-433, @slevenick VCR tests complete for 0199cbb!

@shekhar-433 shekhar-433 force-pushed the add-agentidentity-terraform branch 2 times, most recently from 7ecf6a3 to 18e14ad Compare July 5, 2026 20:04
@modular-magician

modular-magician commented Jul 5, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 7ecf6a3:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 13 files changed, 1984 insertions(+)
google-beta provider View Diff 11 files changed, 1974 insertions(+)
terraform-google-conversion View Diff 3 files changed, 427 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_agent_identity_auth_provider (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_agent_identity_auth_provider" "primary" {
  labels = # value needed
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_agent_identity_auth_provider

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
6695 5993 688 14
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 14 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccAgentIdentityAuthProvider_basic
  • TestAccAgentIdentityAuthProvider_full
  • TestAccAgentIdentityAuthProvider_threeLeggedOauth
  • TestAccAgentIdentityAuthProvider_twoLeggedOauth
  • TestAccAgentIdentityAuthProvider_update
  • TestAccComputeRouterPeer_AddMd5AuthenticationKey
  • TestAccComputeRouterPeer_UpdateMd5AuthenticationKey
  • TestAccContainerCluster_regionalWithNodePool
  • TestAccContainerNodePool_withHostMaintenancePolicy
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccProjectIamMemberRemove_memberInMultipleBindings
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccComputeRouterPeer_AddMd5AuthenticationKey
✅ Log TestAccComputeRouterPeer_UpdateMd5AuthenticationKey
✅ Log TestAccProjectIamMemberRemove_memberInMultipleBindings
❌ Error · Log - TestAccAgentIdentityAuthProvider_basic
❌ Error · Log - TestAccAgentIdentityAuthProvider_full
❌ Error · Log - TestAccAgentIdentityAuthProvider_threeLeggedOauth
❌ Error · Log - TestAccAgentIdentityAuthProvider_twoLeggedOauth
❌ Error · Log - TestAccAgentIdentityAuthProvider_update
❌ Error · Log - TestAccContainerCluster_regionalWithNodePool
❌ Error · Log - TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@shekhar-433, @slevenick VCR tests complete for 7ecf6a3!

@modular-magician

modular-magician commented Jul 5, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 18e14ad:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 12 files changed, 1979 insertions(+)
google-beta provider View Diff 11 files changed, 1974 insertions(+)
terraform-google-conversion View Diff 3 files changed, 427 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_agent_identity_auth_provider (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_agent_identity_auth_provider" "primary" {
  labels = # value needed
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_agent_identity_auth_provider

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
6695 5995 688 12
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccAgentIdentityAuthProvider_basic
  • TestAccAgentIdentityAuthProvider_full
  • TestAccAgentIdentityAuthProvider_threeLeggedOauth
  • TestAccAgentIdentityAuthProvider_twoLeggedOauth
  • TestAccAgentIdentityAuthProvider_update
  • TestAccContainerCluster_regionalWithNodePool
  • TestAccContainerNodePool_withHostMaintenancePolicy
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccProjectIamMemberRemove_memberInMultipleBindings
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccProjectIamMemberRemove_memberInMultipleBindings
❌ Error · Log - TestAccAgentIdentityAuthProvider_basic
❌ Error · Log - TestAccAgentIdentityAuthProvider_full
❌ Error · Log - TestAccAgentIdentityAuthProvider_threeLeggedOauth
❌ Error · Log - TestAccAgentIdentityAuthProvider_twoLeggedOauth
❌ Error · Log - TestAccAgentIdentityAuthProvider_update
❌ Error · Log - TestAccContainerCluster_regionalWithNodePool
❌ Error · Log - TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@shekhar-433, @slevenick VCR tests complete for 18e14ad!

@shekhar-433 shekhar-433 force-pushed the add-agentidentity-terraform branch from 18e14ad to b5d3692 Compare July 5, 2026 20:14
@shekhar-433 shekhar-433 changed the title Add Terraform autogen support and acceptance tests for Agent Identity [Beta] Add Terraform autogen support and acceptance tests for Agent Identity Jul 5, 2026
@shekhar-433 shekhar-433 force-pushed the add-agentidentity-terraform branch from b5d3692 to fbe9218 Compare July 5, 2026 20:22
@modular-magician

modular-magician commented Jul 5, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b5d3692:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 11 files changed, 653 insertions(+)
google-beta provider View Diff 11 files changed, 1976 insertions(+)
terraform-google-conversion View Diff 3 files changed, 427 insertions(+)

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_agent_identity_auth_provider (6 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_agent_identity_auth_provider" "primary" {
  labels = # value needed
}

Missing service labels

The following new resources do not have corresponding service labels:

  • google_agent_identity_auth_provider

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
6695 5996 688 11
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccAgentIdentityAuthProvider_basic
  • TestAccAgentIdentityAuthProvider_full
  • TestAccAgentIdentityAuthProvider_threeLeggedOauth
  • TestAccAgentIdentityAuthProvider_twoLeggedOauth
  • TestAccAgentIdentityAuthProvider_update
  • TestAccContainerCluster_regionalWithNodePool
  • TestAccContainerNodePool_withHostMaintenancePolicy
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
❌ Error · Log - TestAccAgentIdentityAuthProvider_basic
❌ Error · Log - TestAccAgentIdentityAuthProvider_full
❌ Error · Log - TestAccAgentIdentityAuthProvider_threeLeggedOauth
❌ Error · Log - TestAccAgentIdentityAuthProvider_twoLeggedOauth
❌ Error · Log - TestAccAgentIdentityAuthProvider_update
❌ Error · Log - TestAccContainerCluster_regionalWithNodePool
❌ Error · Log - TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@shekhar-433, @slevenick VCR tests complete for b5d3692!

@modular-magician

modular-magician commented Jul 5, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit fbe9218:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 11 files changed, 658 insertions(+)
google-beta provider View Diff 11 files changed, 1981 insertions(+)
terraform-google-conversion View Diff 3 files changed, 427 insertions(+)

Missing service labels

The following new resources do not have corresponding service labels:

  • google_agent_identity_auth_provider

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
6695 5995 688 12
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccAgentIdentityAuthProvider_basic
  • TestAccAgentIdentityAuthProvider_full
  • TestAccAgentIdentityAuthProvider_threeLeggedOauth
  • TestAccAgentIdentityAuthProvider_twoLeggedOauth
  • TestAccAgentIdentityAuthProvider_update
  • TestAccContainerCluster_regionalWithNodePool
  • TestAccContainerNodePool_withHostMaintenancePolicy
  • TestAccDataformConfig_update
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccDataformConfig_update
❌ Error · Log - TestAccAgentIdentityAuthProvider_basic
❌ Error · Log - TestAccAgentIdentityAuthProvider_full
❌ Error · Log - TestAccAgentIdentityAuthProvider_threeLeggedOauth
❌ Error · Log - TestAccAgentIdentityAuthProvider_twoLeggedOauth
❌ Error · Log - TestAccAgentIdentityAuthProvider_update
❌ Error · Log - TestAccContainerCluster_regionalWithNodePool
❌ Error · Log - TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@shekhar-433, @slevenick VCR tests complete for fbe9218!

@shekhar-433

Copy link
Copy Markdown
Author

Hi @slevenick
Can you please enable our api [agentidentity.googleapis.com] in the test project.
Thanks!

@slevenick

Copy link
Copy Markdown
Contributor

/gcbrun

@modular-magician

modular-magician commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit fbe9218:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 11 files changed, 658 insertions(+)
google-beta provider View Diff 11 files changed, 1981 insertions(+)
terraform-google-conversion View Diff 3 files changed, 427 insertions(+)

Missing service labels

The following new resources do not have corresponding service labels:

  • google_agent_identity_auth_provider

If you believe this detection to be incorrect please raise the concern with your reviewer. Googlers: This error is safe to ignore once you've completed go/fix-missing-service-labels.
An override-missing-service-label label can be added to allow merging.

Test report

Analytics

Total Tests Passed Skipped Affected
6700 6000 689 11
Affected Service Packages
  • All service packages are affected

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccAgentIdentityAuthProvider_basic
  • TestAccAgentIdentityAuthProvider_full
  • TestAccAgentIdentityAuthProvider_threeLeggedOauth
  • TestAccAgentIdentityAuthProvider_twoLeggedOauth
  • TestAccAgentIdentityAuthProvider_update
  • TestAccContainerCluster_regionalWithNodePool
  • TestAccContainerNodePool_withHostMaintenancePolicy
  • TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
  • TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
  • TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
  • TestAccPubsubSubscription_pubsubSubscriptionTagsExample

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccAgentIdentityAuthProvider_basic
✅ Log TestAccAgentIdentityAuthProvider_full
✅ Log TestAccAgentIdentityAuthProvider_threeLeggedOauth
✅ Log TestAccAgentIdentityAuthProvider_twoLeggedOauth
✅ Log TestAccAgentIdentityAuthProvider_update
❌ Error · Log - TestAccContainerCluster_regionalWithNodePool
❌ Error · Log - TestAccContainerNodePool_withHostMaintenancePolicy
❌ Error · Log - TestAccDataprocMetastoreService_dataprocMetastoreServicePrivateServiceConnectExample
❌ Error · Log - TestAccDiscoveryEngineDataStore_discoveryengineDatastoreKmsKeyNameExample
❌ Error · Log - TestAccManagedKafkaConnector_managedkafkaConnectorBasicExample
❌ Error · Log - TestAccPubsubSubscription_pubsubSubscriptionTagsExample

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@shekhar-433, @slevenick VCR tests complete for fbe9218!

@slevenick

Copy link
Copy Markdown
Contributor

Please do a local review with a Google engineer from the service team as described at go/terraform-service-review. Let me know when that's finished and I'll follow up with final review & merge.

@shekhar-433

Copy link
Copy Markdown
Author

Please do a local review with a Google engineer from the service team as described at go/terraform-service-review. Let me know when that's finished and I'll follow up with final review & merge.

Sure, Thanks.
I believe these above detections are unrelated to ours change.
FYI: Enroll Agent Identity in Graphite Terraform self-service onboarding [cl/943737806]

@shekhar-433

Copy link
Copy Markdown
Author

Hi @Anurag168
Can you please review this cl.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants