bigqueryreservation: add labels field to google_bigquery_reservation#18180
bigqueryreservation: add labels field to google_bigquery_reservation#18180joyan0930 wants to merge 1 commit into
labels field to google_bigquery_reservation#18180Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @malhotrasagar2212, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 21e9df6: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
🟢 All tests passed! View the recording VCR build log or the debug logs folder for detailed results. @joyan0930, @sachinpro, @malhotrasagar2212 VCR tests complete for 21e9df6! |
Fixes hashicorp/terraform-provider-google#25304.
This PR adds a
labelsfield to thegoogle_bigquery_reservationresource. The BigQuery Reservation v1 API already supports alabelsmap on the Reservation resource, but the Terraform provider does not expose it. Exposing labels enables cost allocation via billing export label filters when multiple teams' reservations are managed in a single admin project.Changes
mmv1/products/bigqueryreservation/Reservation.yaml: addlabels(KeyValueLabels). The resource already usesupdate_mask: true/update_verb: PATCH, solabels,terraform_labelsandeffective_labelshandling is fully generated with no custom code.bigquery_reservation_basic.tf.tmpl: addlabelsto the documented sample.resource_bigquery_reservation_test.go.tmpl: addTestAccBigqueryReservation_labels_updatecovering create → update → import (withImportStateVerifyIgnoreforlabels/terraform_labels), following the pattern fromeventarc: addlabelsfield inchannelresource #15463 (eventarc channel labels).Local verification
make provider VERSION=ga PRODUCT=bigqueryreservationsucceeds; generated diff includes the labels schema,tpgresource.SetLabelsDiff, andlabelsin the PATCH update mask.go build,go vet, andgofmtpass on the generatedgoogle/services/bigqueryreservationpackage.Note: an earlier draft of this change exists as jbbqqf#4, but it was only opened on a personal fork and has been inactive; this PR is a complete version including tests and docs.
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.