bigtable: Fix bigtable_custom_endpoint ignoring config and dropping gRPC endpoints#18187
Open
mutianf wants to merge 1 commit into
Open
bigtable: Fix bigtable_custom_endpoint ignoring config and dropping gRPC endpoints#18187mutianf wants to merge 1 commit into
mutianf wants to merge 1 commit into
Conversation
…ped by gRPC clients Reapplies GoogleCloudPlatform#16958 (reverted in GoogleCloudPlatform#17697) with a fix for the "missing port in address" gRPC dial failure that broke nightly tests. `option.WithEndpoint` for native gRPC clients requires a `host:port` address, so a helper appends `:443` when the endpoint carries no explicit port. Adds a unit test for the endpoint transform to guard against regressing the port bug. ```release-note:bug bigtable: Fixed an issue where `bigtable_custom_endpoint` and `universe_domain` were ignored when creating Bigtable resources. ```
modular-magician
added
the
awaiting-approval
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
rameshdharan
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recreate PR #16958 and fix the endpoint issue it introduced.
Fixes hashicorp/terraform-provider-google#26764
This PR resolves an issue where the Google Cloud Terraform provider drops the bigtable_custom_endpoint and universe_domain when provisioning Bigtable resources because native gRPC clients are initialized instead of the standard HTTP clients.
Changes:
Mapped the parsed bigtable_custom_endpoint variable to config.BigtableAdminBasePath in config.go (and the config.go.tmpl).
Updated the BigtableClientFactory to accept both BasePath (Data) and AdminBasePath (Admin), and UniverseDomain.
Stripped the standard https:// prefix and trailing slashes from the endpoints before initializing the native gRPC clients via option.WithEndpoint().
Applied option.WithUniverseDomain() when a Universe Domain is configured.
Adapted the Data API endpoint prefix (bigtableadmin. -> bigtable.) conditionally to preserve distinct Data endpoints if they are ever split in the schema.