fix (compute): enable_proxy_protocol not being disableable on google_compute_service_attachment.

[ricardgardella]

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

compute: added `send_empty_value` field to `enableProxyProtocol` on `ServiceAttachment` resource

[github-actions]

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[ricardgardella]

Hello, can someone take a look to this PR. As far as I checked should be good to go.

Thanks!

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit eab9478:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	2 files changed, 27 insertions(+), 7 deletions(-)
google-beta provider	View Diff	2 files changed, 27 insertions(+), 7 deletions(-)
terraform-google-conversion	View Diff	1 file changed, 1 insertion(+), 1 deletion(-)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
1508	1401	94	13

Affected Service Packages

• compute

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 13 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

• TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample
• TestAccComputeRouterPeer_AddMd5AuthenticationKey
• TestAccComputeServiceAttachment_connectionLimitUpdate
• TestAccComputeServiceAttachment_serviceAttachmentBasicExampleGateway
• TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate
• TestAccComputeServiceAttachment_serviceAttachmentCrossRegionIlbExample
• TestAccComputeServiceAttachment_serviceAttachmentEndpointUrl
• TestAccComputeServiceAttachment_serviceAttachmentExplicitNetworksExample
• TestAccComputeServiceAttachment_serviceAttachmentTunnelingConfigExample
• TestAccComputeServiceAttachment_targetServiceInPlaceUpdate
• TestAccComputeServiceAttachment_tunnelingConfigUpdate
• TestAccComputeSharedVpc_basic
• TestAccDataSourceGoogleComputeServiceAttachment_basic

View the replaying VCR build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccComputeRegionNetworkEndpointGroup_regionNetworkEndpointGroupPscServiceAttachmentExample
✅ Log	✅	TestAccComputeRouterPeer_AddMd5AuthenticationKey
✅ Log	✅	TestAccComputeServiceAttachment_connectionLimitUpdate
✅ Log	✅	TestAccComputeServiceAttachment_serviceAttachmentBasicExampleGateway
✅ Log	✅	TestAccComputeServiceAttachment_serviceAttachmentCrossRegionIlbExample
✅ Log	✅	TestAccComputeServiceAttachment_serviceAttachmentEndpointUrl
✅ Log	✅	TestAccComputeServiceAttachment_serviceAttachmentExplicitNetworksExample
✅ Log	✅	TestAccComputeServiceAttachment_serviceAttachmentTunnelingConfigExample
✅ Log	✅	TestAccComputeServiceAttachment_targetServiceInPlaceUpdate
✅ Log	✅	TestAccComputeServiceAttachment_tunnelingConfigUpdate
✅ Log	✅	TestAccComputeSharedVpc_basic
✅ Log	✅	TestAccDataSourceGoogleComputeServiceAttachment_basic
❌ Error · Log	-	TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate

Caution

Issues requiring attention before PR completion

🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@ricardgardella, @BBBmau VCR tests complete for eab9478!

[BBBmau]

this configuration is have an affect on the send_propagated_connection_limit_if_zero field since it's set to true in the configuration but then changed to false due to enable_proxy_protocol being set to false

stdout:
=== RUN   TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate
=== PAUSE TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate
=== CONT  TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate
    resource_compute_service_attachment_test.go:39: Step 9/9 error running import: ImportStateVerify attributes not equivalent. Difference is shown below. The - symbol indicates attributes missing after import.
        
        Â Â map[string]string{
        -Â 	"send_propagated_connection_limit_if_zero": "true",
        +Â 	"send_propagated_connection_limit_if_zero": "false",
        Â Â }
--- FAIL: TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate (237.48s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-google-beta/google-beta/services/compute	237.576s
FAIL
stderr:

[ricardgardella]

Working on it. Will mention you once it's ready and tests pass.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit cb6db71:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository	Diff Link	Changes
google provider	View Diff	2 files changed, 29 insertions(+), 7 deletions(-)
google-beta provider	View Diff	2 files changed, 29 insertions(+), 7 deletions(-)
terraform-google-conversion	View Diff	1 file changed, 1 insertion(+), 1 deletion(-)

Test report

Analytics

Total Tests	Passed	Skipped	Affected
1518	1423	94	1

Affected Service Packages

• compute

Learn how VCR tests work

---

Step 1: Replaying Mode

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests

• TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate

View the replaying VCR build log

---

Step 2: Recording Mode

Recording Mode	Replaying Rerun	Test Name
✅ Log	✅	TestAccComputeServiceAttachment_serviceAttachmentBasicExampleUpdate

🟢 All tests passed!

View the recording VCR build log or the debug logs folder for detailed results.

@ricardgardella, @BBBmau VCR tests complete for cb6db71!

[BBBmau]

LGTM!