Add enable_ssh to Dataproc Cluster IdentityConfig#18200
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
slevenick
left a comment
There was a problem hiding this comment.
Please do a local review with a Google engineer from the service team as described at go/terraform-service-review. Let me know when that's finished and I'll follow up with final review & merge.
Please also add a test that sets enable_ssh to false
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 9ee3290: Diff reportYour PR generated the following diffs in downstream repositories:
Errors
Step 1: Replaying Mode Caution Build Failure during VCR tests 🔴 REPLAYING mode: The following packages failed to build:
Please fix the compilation errors to complete your PR. View the build log |
This PR adds the optional
enable_sshfield to Dataproc Cluster'sidentity_config, allowing users to enable/disable SSH access for the cluster.Related changes:
enable_sshfield toIdentityConfigschema and meta.TestAccDataprocCluster_withIdentityConfigto test the new field.