Skip to content

Add enable_ssh to Dataproc Cluster IdentityConfig#18200

Open
rui5i wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
rui5i:dataproc-enable-ssh
Open

Add enable_ssh to Dataproc Cluster IdentityConfig#18200
rui5i wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
rui5i:dataproc-enable-ssh

Conversation

@rui5i

@rui5i rui5i commented Jul 7, 2026

Copy link
Copy Markdown

This PR adds the optional enable_ssh field to Dataproc Cluster's identity_config, allowing users to enable/disable SSH access for the cluster.

Related changes:

  • Adds enable_ssh field to IdentityConfig schema and meta.
  • Updates expand/flatten functions to handle the new field.
  • Updates TestAccDataprocCluster_withIdentityConfig to test the new field.
dataproc: added `enable_ssh` field to `google_dataproc_cluster` resource

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jul 7, 2026
@github-actions github-actions Bot requested a review from slevenick July 7, 2026 05:41
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@slevenick slevenick left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do a local review with a Google engineer from the service team as described at go/terraform-service-review. Let me know when that's finished and I'll follow up with final review & merge.

Please also add a test that sets enable_ssh to false

@modular-magician modular-magician added service/dataproc and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jul 8, 2026
@modular-magician

modular-magician commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 9ee3290:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 3 files changed, 14 insertions(+), 1 deletion(-)
google-beta provider View Diff 3 files changed, 14 insertions(+), 1 deletion(-)

Errors

google provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

google-beta provider:

  • The diff processor failed to build. This is usually due to the downstream provider failing to compile.

Step 1: Replaying Mode

Caution

Build Failure during VCR tests

🔴 REPLAYING mode: The following packages failed to build:

  • dataproc

Please fix the compilation errors to complete your PR.

View the build log

@rui5i VCR tests complete for 9ee3290!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants