Skip to content

Add IAM policy support for google_iap_agent_registry_mcp_server#18202

Closed
JamesDuncanNz wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
JamesDuncanNz:add-iap-agent-registry-mcp-server-iam
Closed

Add IAM policy support for google_iap_agent_registry_mcp_server#18202
JamesDuncanNz wants to merge 1 commit into
GoogleCloudPlatform:mainfrom
JamesDuncanNz:add-iap-agent-registry-mcp-server-iam

Conversation

@JamesDuncanNz

Copy link
Copy Markdown
Contributor

This change adds a new resources under the IAP product to support IAM policy configurations:

  • google_iap_agent_registry_mcp_server_iam

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

`google_iap_agent_registry_endpoint_iam_policy`
`google_iap_agent_registry_endpoint_iam_binding`
`google_iap_agent_registry_endpoint_iam_member`

@modular-magician

modular-magician commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b505ad7:

Diff report

Your PR generated the following diffs in downstream repositories:

Repository Diff Link Changes
google provider View Diff 4 files changed, 1426 insertions(+)
google-beta provider View Diff 4 files changed, 1426 insertions(+)

Test report

Important

Manual Verification Required

VCR cannot automatically execute the following tests added in this PR. Please verify them manually:

🔴 TestAccIapAgentRegistryMcpServerIamBindingGenerated_withAndWithoutCondition
🔴 TestAccIapAgentRegistryMcpServerIamMemberGenerated_withAndWithoutCondition

Analytics

Total Tests Passed Skipped Affected
129 93 30 6
Affected Service Packages
  • iap

Learn how VCR tests work


Step 1: Replaying Mode

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit.

Click here to see the affected tests
  • TestAccIapAgentRegistryMcpServerIamBindingGenerated
  • TestAccIapAgentRegistryMcpServerIamBindingGenerated_withCondition
  • TestAccIapAgentRegistryMcpServerIamMemberGenerated
  • TestAccIapAgentRegistryMcpServerIamMemberGenerated_withCondition
  • TestAccIapAgentRegistryMcpServerIamPolicyGenerated
  • TestAccIapAgentRegistryMcpServerIamPolicyGenerated_withCondition

View the replaying VCR build log


Step 2: Recording Mode

Recording Mode Replaying Rerun Test Name
✅ Log TestAccIapAgentRegistryMcpServerIamBindingGenerated
✅ Log TestAccIapAgentRegistryMcpServerIamBindingGenerated_withCondition
✅ Log TestAccIapAgentRegistryMcpServerIamMemberGenerated
✅ Log TestAccIapAgentRegistryMcpServerIamMemberGenerated_withCondition
✅ Log TestAccIapAgentRegistryMcpServerIamPolicyGenerated
✅ Log TestAccIapAgentRegistryMcpServerIamPolicyGenerated_withCondition

Caution

Issues requiring attention before PR completion

🔴 Manual Verification Required: New tests were added that are skipped in presubmit tests. See the "Manual Verification Required" section at the top for details.

Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer.

View the recording VCR build log or the debug logs folder for detailed results.

@JamesDuncanNz VCR tests complete for b505ad7!

@JamesDuncanNz JamesDuncanNz marked this pull request as ready for review July 7, 2026 11:43
@github-actions github-actions Bot requested a review from ScottSuarez July 7, 2026 11:44
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@swamitagupta

swamitagupta commented Jul 7, 2026

Copy link
Copy Markdown
Member

Hey @JamesDuncanNz ,
I'm from the IAP service team. This IAP support is being added by #18088

@JamesDuncanNz

Copy link
Copy Markdown
Contributor Author

Hey @JamesDuncanNz ,

I'm from the IAP service team. This IAP support is being added by #18088

@swamitagupta Thanks, sorry I missed that PR! I'll close this one out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants