Added missing update_mask parameter to update operation#18203
Conversation
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @slevenick, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
88734b0 to
943a1b8
Compare
943a1b8 to
b89db4b
Compare
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 943a1b8: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @xpr0ger, @slevenick VCR tests complete for 943a1b8! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit b89db4b: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode 🟢 All tests passed in Replaying mode! No Recording was needed. View the replaying VCR build log @xpr0ger, @slevenick VCR tests complete for b89db4b! |
slevenick
left a comment
There was a problem hiding this comment.
Please do a local review with a Google engineer from the service team as described at go/terraform-service-review. Let me know when that's finished and I'll follow up with final review & merge.
slevenick
left a comment
There was a problem hiding this comment.
Please add an update test for this resource and this field. I'd like to make sure this keeps working
Added update_mask parameter for update private cloud request b/529713679
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.