Update ces fields#18205
Conversation
…oyment, Example, Tool, and Toolset resources
|
Googlers: For automatic test runs see go/terraform-auto-test-runs. @SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 4ef059d: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_ces_agent" "primary" {
transfer_rules {
deterministic_transfer {
python_code_condition {
python_code = # value needed
}
}
disable_planner_transfer {
expression_condition {
expression = # value needed
}
}
}
}
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 13 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @mp32154, @SirGitsalot VCR tests complete for 4ef059d! |
…d disable_planner_transfer under agent transfer_rules
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit f8065e8: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @mp32154, @SirGitsalot VCR tests complete for f8065e8! |
… values in ces_app_test.go
…eployment, and guardrail tests
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 2a12062: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @mp32154, @SirGitsalot VCR tests complete for 2a12062! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit dad3de3: Diff reportYour PR generated the following diffs in downstream repositories:
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 18 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @mp32154, @SirGitsalot VCR tests complete for dad3de3! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit 1a1368d: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_ces_deployment" "primary" {
channel_profile {
instagram_config {
instagram_account_id = # value needed
}
noise_suppression_level = # value needed
whatsapp_config {
phone_number = # value needed
phone_number_id = # value needed
waba_id = # value needed
}
}
experiment_config {
version_release {
state = # value needed
traffic_allocations {
app_version = # value needed
id = # value needed
traffic_percentage = # value needed
}
}
}
instagram_credentials {
auth_code = # value needed
conversation_profile_id = # value needed
}
whatsapp_credentials {
auth_code = # value needed
business_account_id = # value needed
conversation_profile_id = # value needed
phone_number = # value needed
pin = # value needed
waba_id = # value needed
}
}
Resource: resource "google_ces_guardrail" "primary" {
model_armor {
fail_open = # value needed
model_armor_template = # value needed
sanitization_scope = # value needed
}
}
Resource: resource "google_ces_toolset" "primary" {
connector_toolset {
auth_config {
oauth2_auth_code_config {
oauth_token = # value needed
}
oauth2_jwt_bearer_config {
client_key = # value needed
issuer = # value needed
subject = # value needed
}
}
connection = # value needed
connector_actions {
connection_action_id = # value needed
entity_operation {
entity_id = # value needed
operation = # value needed
}
input_fields = # value needed
output_fields = # value needed
}
}
mcp_toolset {
tool_overrides {
description_override = # value needed
name_override = # value needed
tool = # value needed
}
}
timeout = # value needed
}
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 16 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @mp32154, @SirGitsalot VCR tests complete for 1a1368d! |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes for commit baccd81: Diff reportYour PR generated the following diffs in downstream repositories:
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_ces_deployment" "primary" {
channel_profile {
instagram_config {
instagram_account_id = # value needed
}
noise_suppression_level = # value needed
whatsapp_config {
phone_number = # value needed
phone_number_id = # value needed
waba_id = # value needed
}
}
experiment_config {
version_release {
state = # value needed
traffic_allocations {
app_version = # value needed
id = # value needed
traffic_percentage = # value needed
}
}
}
instagram_credentials {
auth_code = # value needed
conversation_profile_id = # value needed
}
whatsapp_credentials {
auth_code = # value needed
business_account_id = # value needed
conversation_profile_id = # value needed
phone_number = # value needed
pin = # value needed
waba_id = # value needed
}
}
Resource: resource "google_ces_guardrail" "primary" {
model_armor {
fail_open = # value needed
model_armor_template = # value needed
sanitization_scope = # value needed
}
}
Resource: resource "google_ces_toolset" "primary" {
connector_toolset {
auth_config {
oauth2_auth_code_config {
oauth_token = # value needed
}
oauth2_jwt_bearer_config {
client_key = # value needed
issuer = # value needed
subject = # value needed
}
}
connection = # value needed
connector_actions {
connection_action_id = # value needed
entity_operation {
entity_id = # value needed
operation = # value needed
}
input_fields = # value needed
output_fields = # value needed
}
}
mcp_toolset {
tool_overrides {
description_override = # value needed
name_override = # value needed
tool = # value needed
}
}
timeout = # value needed
}
Test reportAnalytics
Affected Service Packages
Step 1: Replaying Mode Action takenFound 16 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
View the replaying VCR build log Step 2: Recording Mode
Caution Issues requiring attention before PR completion 🔴 Initial Recording Failed: Some tests failed during the recording step. See the table above for details. Please address these issues to complete your PR. If you believe these detections are incorrect or unrelated to your change, please raise the concern with your reviewer. View the recording VCR build log or the debug logs folder for detailed results. @mp32154, @SirGitsalot VCR tests complete for baccd81! |
Description
This PR adds support for several missing API fields across Google Cloud Event Threat Detection (CES) resources in Magic Modules and updates integration tests to cover all new fields.
Changes by resource:
Agent(Agent.yaml):proactiveExecutionEnabled(type: Boolean) toafterAgentCallbacks,afterModelCallbacks,afterToolCallbacks,beforeAgentCallbacks,beforeModelCallbacks, andbeforeToolCallbacks.languageCodeVariableunderremoteDialogflowAgent.transferRulesblock for defining routing/escalation logic.App(App.yaml):defaultChannelProfile.instagramConfig.instagramAccountId,defaultChannelProfile.noiseSuppressionLevel,defaultChannelProfile.whatsappConfig(phoneNumber,phoneNumberId,wabaId).defaultChannelProfile.webWidgetConfig.securitySettings(allowedOrigins,enableOriginCheck,enablePublicAccess,enableRecaptcha).errorHandlingSettings(endSessionConfig.escalateSession,errorHandlingStrategy,fallbackResponseConfig.customFallbackMessages,fallbackResponseConfig.maxFallbackAttempts).evaluationMetricsThresholds(goldenEvaluationMetricsThresholds.toolMatchingSettings.extraToolCallBehavior,goldenEvaluationMetricsThresholds.turnLevelMetricsThresholds.semanticSimilarityChannel,goldenHallucinationMetricBehavior,scenarioHallucinationMetricBehavior).lockedboolean.loggingSettings(conversationLoggingSettings.retentionWindow,evaluationAudioRecordingConfig,metricAnalysisSettings.llmMetricsOptedOut,unredactedAudioRecordingConfig,unredactedBigqueryExportSettings).maxItems,maximum,minItems,minimum).vpcScSettings.allowedOrigins.Deployment(Deployment.yaml):channelProfileproperties (instagramConfig,noiseSuppressionLevel,whatsappConfig).experimentConfig.versionReleaseconfiguration.instagramCredentials,whatsappCredentials).Example(Example.yaml):blobdata/mimeType,defaultVariables,payload,transcript).Guardrail(Guardrail.yaml):proactiveExecutionEnabledto all callback configurations.modelArmorconfiguration block (failOpen,modelArmorTemplate,sanitizationScope).Tool(Tool.yaml):scopesto service account authentications.serviceDirectoryConfigunder python function configurations.Toolset(Toolset.yaml):connectorToolsetconfiguration block.toolOverridestomcpToolset.timeout.Verification
gaversion) locally and confirmed successful build.Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.