Deprecate InheritManifest, minimizeJar, and TransformerContext.Builder - #2190
Merged
Conversation
Original commit on main: f7d8d1b
Goooler
force-pushed
the
g/deprecations
branch
from
August 13, 2026 13:48
a2ca372 to
6d4fdb7
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Ports deprecation annotations for legacy APIs from main into the 8.x line so consumers get consistent warnings and migration guidance.
Changes:
- Deprecates
TransformerContext.Builderby replacing Groovy’s@Buildergeneration with an explicit deprecatedBuilder+builder()factory. - Deprecates legacy
minimizeJarproperty accessors onShadowJarin favor ofminimize(). - Deprecates
InheritManifestand records the deprecations in the Unreleased changelog.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/main/groovy/com/github/jengelman/gradle/plugins/shadow/transformers/TransformerContext.groovy | Removes Groovy @Builder and adds an explicit deprecated builder API to preserve compatibility while warning users. |
| src/main/groovy/com/github/jengelman/gradle/plugins/shadow/tasks/ShadowJar.java | Adds deprecated getMinimizeJar/setMinimizeJar accessors pointing users at minimize(). |
| src/main/groovy/com/github/jengelman/gradle/plugins/shadow/tasks/InheritManifest.groovy | Deprecates the legacy manifest interface. |
| src/docs/changes/README.md | Documents the newly added deprecations under Unreleased. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Member
Author
|
Merged into #2186. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port deprecation annotations for legacy APIs from
mainto8.x.Deprecations
InheritManifest#1722 - DeprecateInheritManifestminimizeJarproperty #2124 - DeprecateminimizeJarpropertyTransformerContext.Builder#2184 - DeprecateTransformerContext.Builder