Skip to content

Break out helper functions from the frontend's managers and stores #3920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Keavon merged 2 commits into from
Mar 20, 2026
Merged

Break out helper functions from the frontend's managers and stores #3920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
be0bef7
Move destructor call to each manager/store constructor for safety
Keavon Mar 20, 2026
151b10c
Break out utility functions
Keavon Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/components/floating-menus/Dialog.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
<script lang="ts">
import { getContext, onMount } from "svelte";

import { wipeDocuments } from "@graphite/managers/persistence";
import type { DialogStore } from "@graphite/stores/dialog";
import { crashReportUrl } from "@graphite/utility-functions/crash-report";
import { wipeDocuments } from "@graphite/utility-functions/persistence";

import FloatingMenu from "@graphite/components/layout/FloatingMenu.svelte";
import LayoutCol from "@graphite/components/layout/LayoutCol.svelte";
Expand Down
85 changes: 3 additions & 82 deletions frontend/src/managers/clipboard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
import type { Editor } from "@graphite/editor";
import { insertAtCaret, readAtCaret } from "@graphite/utility-functions/clipboard";

let editorRef: Editor | undefined = undefined;

export function createClipboardManager(editor: Editor) {
destroyClipboardManager();

editorRef = editor;

editor.subscriptions.subscribeFrontendMessage("TriggerClipboardWrite", (data) => {
Expand All @@ -28,89 +31,7 @@ export function destroyClipboardManager() {
editor.subscriptions.unsubscribeFrontendMessage("TriggerSelectionWrite");
}

function readAtCaret(cut: boolean): string | undefined {
const element = window.document.activeElement;

if (element instanceof HTMLInputElement || element instanceof HTMLTextAreaElement) {
const start = element.selectionStart;
const end = element.selectionEnd;

if ((!start && start !== 0) || (!end && end !== 0) || start === end) {
return undefined;
}

const value = element.value;
const selectedText = value.slice(start, end);

if (cut) {
element.value = value.slice(0, start) + value.slice(end);

element.selectionStart = element.selectionEnd = start;
element.dispatchEvent(new Event("input", { bubbles: true }));
}

return selectedText;
}

const selection = window.getSelection();
if (!selection || selection.rangeCount === 0) {
return undefined;
}

const selectedText = String(selection);
if (!selectedText) return undefined;

if (cut) {
const range = selection.getRangeAt(0);
range.deleteContents();

range.collapse(true);
selection.removeAllRanges();
selection.addRange(range);
}

return selectedText;
}

function insertAtCaret(text: string) {
const element = window.document.activeElement;

if (!element) return;

if (element instanceof HTMLInputElement || element instanceof HTMLTextAreaElement) {
const start = element.selectionStart;
const end = element.selectionEnd;

if ((!start && start !== 0) || (!end && end !== 0)) return;

const value = element.value;

element.value = value.slice(0, start) + text + value.slice(end);

const newPos = start + text.length;
element.selectionStart = element.selectionEnd = newPos;
} else if (element instanceof HTMLElement && element.isContentEditable) {
const selection = window.getSelection();
if (!selection || selection.rangeCount === 0) return;

const range = selection.getRangeAt(0);
range.deleteContents();

const textNode = window.document.createTextNode(text);
range.insertNode(textNode);

range.setStartAfter(textNode);
range.collapse(true);

selection.removeAllRanges();
selection.addRange(range);
}

element.dispatchEvent(new Event("input", { bubbles: true }));
}

// Self-accepting HMR: tear down the old instance and re-create with the new module's code
import.meta.hot?.accept((newModule) => {
destroyClipboardManager();
if (editorRef) newModule?.createClipboardManager(editorRef);
});
3 changes: 2 additions & 1 deletion frontend/src/managers/fonts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ let editorRef: Editor | undefined = undefined;
let abortController: AbortController | undefined = undefined;

export function createFontsManager(editor: Editor) {
destroyFontsManager();

editorRef = editor;
abortController = new AbortController();

Expand Down Expand Up @@ -66,6 +68,5 @@ export function destroyFontsManager() {

// Self-accepting HMR: tear down the old instance and re-create with the new module's code
import.meta.hot?.accept((newModule) => {
destroyFontsManager();
if (editorRef) newModule?.createFontsManager(editorRef);
});
3 changes: 2 additions & 1 deletion frontend/src/managers/hyperlink.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ import type { Editor } from "@graphite/editor";
let editorRef: Editor | undefined = undefined;

export function createHyperlinkManager(editor: Editor) {
destroyHyperlinkManager();

editorRef = editor;

editor.subscriptions.subscribeFrontendMessage("TriggerVisitLink", async (data) => {
Expand All @@ -19,6 +21,5 @@ export function destroyHyperlinkManager() {

// Self-accepting HMR: tear down the old instance and re-create with the new module's code
import.meta.hot?.accept((newModule) => {
destroyHyperlinkManager();
if (editorRef) newModule?.createHyperlinkManager(editorRef);
});
Loading
Loading