Skip to content

Add ESLint to CI#57

Merged
dduugg merged 3 commits intomainfrom
dug/add-lint-to-ci
Apr 23, 2026
Merged

Add ESLint to CI#57
dduugg merged 3 commits intomainfrom
dug/add-lint-to-ci

Conversation

@dduugg
Copy link
Copy Markdown
Contributor

@dduugg dduugg commented Apr 22, 2026

Summary

Adds yarn lint as a required PR check and replaces the broken eslint-config-gusto setup with a minimal ESLint flat config appropriate for this Node.js plugin.

Why the old config was broken:

  • .eslintrc.js used module.exports which fails in an ESM project ("type": "module")
  • eslint-config-gusto is a React/TypeScript config — inappropriate for a Node.js plugin, and was the source of the axe-core license violation and typosquat security alerts on the previous PR

Changes

  • Replace eslint-config-gusto with eslint + @eslint/js (ESLint's own recommended config)
  • Replace .eslintrc.js with eslint.config.js (ESLint 9 flat config, ESM-compatible)
  • Delete .prettierrc.js (was re-exporting Prettier config from eslint-config-gusto)
  • Fix two lint errors surfaced by the new config in verifyConditions.js: useless null initializer and unused catch variable
  • Split lint and jest into separate parallel jobs so failures in one don't mask the other

@dduugg dduugg marked this pull request as ready for review April 22, 2026 00:31
@dduugg dduugg requested a review from a team as a code owner April 22, 2026 00:31
@dduugg dduugg force-pushed the dug/add-lint-to-ci branch from 1fb7d79 to b3510ee Compare April 22, 2026 00:36
@dduugg dduugg enabled auto-merge (squash) April 22, 2026 00:37
@dduugg dduugg requested a review from a team April 22, 2026 16:10
Comment thread package.json Outdated
@dduugg dduugg merged commit e725f9c into main Apr 23, 2026
7 checks passed
@dduugg dduugg deleted the dug/add-lint-to-ci branch April 23, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants