Conversation
1fb7d79 to
b3510ee
Compare
dduugg
commented
Apr 22, 2026
dkisselev
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
yarn lintas a required PR check and replaces the brokeneslint-config-gustosetup with a minimal ESLint flat config appropriate for this Node.js plugin.Why the old config was broken:
.eslintrc.jsusedmodule.exportswhich fails in an ESM project ("type": "module")eslint-config-gustois a React/TypeScript config — inappropriate for a Node.js plugin, and was the source of theaxe-corelicense violation and typosquat security alerts on the previous PRChanges
eslint-config-gustowitheslint+@eslint/js(ESLint's own recommended config).eslintrc.jswitheslint.config.js(ESLint 9 flat config, ESM-compatible).prettierrc.js(was re-exporting Prettier config fromeslint-config-gusto)verifyConditions.js: uselessnullinitializer and unused catch variablelintandjestinto separate parallel jobs so failures in one don't mask the other