Skip to content

Conversation

@jreadey
Copy link
Member

@jreadey jreadey commented Dec 4, 2025

Re-raising Cancelled exceptions based on this guidance:
https://docs.python.org/3.8/library/asyncio-exceptions.html#asyncio.CancelledError


Important

Re-raise CancelledError exceptions and improve logging and node management in HSDS.

  • Exception Handling:
    • Re-raise CancelledError instead of converting to HTTPInternalServerError in azureBlobClient.py and fileClient.py.
  • Logging:
    • Change log level from warn to info for certain messages in azureBlobClient.py and fileClient.py.
    • Minor log message concatenation improvements in datanode_lib.py.
  • Cluster Management:
    • Add active_sn_ids and active_dn_ids management in headnode.py for better node tracking.
    • Modify isClusterReady() and register() in headnode.py to use active node lists.
  • Miscellaneous:
    • Fix typo in headnode.py.
    • Add getNodeUrls() function in headnode.py for URL management.

This description was created by Ellipsis for 5803e48. You can customize this summary. It will automatically update as commits are pushed.

if pending_s3_write[obj_id] != now:
msg = "pending_s3_write timestamp got updated unexpectedly "
msg += f"for {obj_id}"
msg = f"pending_s3_write timestamp for got updated unexpectedly for {obj_id}"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in the error message: "pending_s3_write timestamp for got updated unexpectedly for {obj_id}" seems to have an extra or misplaced 'for'. Consider revising it, e.g., "pending_s3_write timestamp got updated unexpectedly for {obj_id}".

Suggested change
msg = f"pending_s3_write timestamp for got updated unexpectedly for {obj_id}"
msg = f"pending_s3_write timestamp got updated unexpectedly for {obj_id}"

@jreadey jreadey merged commit a49cdd0 into master Dec 4, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants