Skip to content

改进图像类型探测功能 - #6613

Open
Glavo wants to merge 2 commits into
HMCL-dev:mainfrom
Glavo:svg
Open

改进图像类型探测功能#6613
Glavo wants to merge 2 commits into
HMCL-dev:mainfrom
Glavo:svg

Conversation

@Glavo

@Glavo Glavo commented Aug 5, 2026

Copy link
Copy Markdown
Member

No description provided.

@Glavo

Glavo commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

@codex review

@github-actions github-actions Bot added the 100+ label Aug 5, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c7f8cb8a94

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +322 to +324
return next == '>'
|| isXmlWhitespace(next)
|| next == '/' && end + 1 < limit && data[end + 1] == '>';

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Accept prefixed SVG roots during sniffing

When SVG loader selection depends on sniffing rather than a .svg extension or image/svg+xml content type, a valid namespaced root such as <svg:svg xmlns:svg="http://www.w3.org/2000/svg"> now falls through to the JavaFX default loader because : is not accepted after the <svg prefix. The previous prefix check would route this case to the SVG loader, so prefixed SVG documents with unknown extensions or generic content types regress to failing/non-SVG loading; please account for prefixed SVG root names instead of treating only >, whitespace, and /> as valid boundaries.

Useful? React with 👍 / 👎.

@3gf8jv4dv

Copy link
Copy Markdown
Contributor

加一个 resolves #6591

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants