fix(ci): count PR size with three-dot diff - #33
Merged
Conversation
Two-dot base..head includes main-only commits when a branch is behind main, so small PRs could fail the 400-line limit. Use base...head to match GitHub's Files changed scope. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
base...head) so the check matches GitHub's "Files changed" tab.base..headfalsely fails branches that are behindmain: it treats teammates' merges onmainas part of the PR.Test plan
main; "Diff stays reviewable" should pass.Oversized:in the description).Made with Cursor