Skip bottle relocation on Apple Silicon with default prefix #19665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change skips the relocation process for bottles on Apple Silicon Macs when using the default prefix (/opt/homebrew). Relocation was initially needed for Intel Macs to avoid wide-reaching replacements with false positives, but is unnecessary for Apple Silicon where the default prefix is unique. Benefits: - Simplifies and speeds up bottle pouring on Apple Silicon - Potentially enables code-signing of homebrew-core packages - Improves security by avoiding binary modification post-build A --force-bottle-relocation flag is added for edge cases where relocation might still be needed. Fixes Homebrew#19247
…out, remove force flag
1. Add binary relocation detection using RubyMacho 2. Update skip_relocation_for_apple_silicon? to consider binary analysis 3. Track relocation status in bottle tab metadata 4. Update keg relocation methods to use new functionality This implements the remaining suggestions from issue Homebrew#19247.
samuelarogbonlo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip bottle relocation on Apple Silicon with default prefix
This PR skips the relocation process for bottles on Apple Silicon Macs when using the default prefix (/opt/homebrew), as it's unnecessary when the prefix is unique.
Benefits
Implementation
Note: Due to platform differences between Apple Silicon and Linux, autogenerated completion files will need to be updated in CI.
Fixes #19247