Skip to content

Conversation

@p-linnane
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

We've completed our migration from using pypi_formula_mappings.json to the new pypi_packages DSL (thanks again @botantony for all the great work there!)

This PR removes the log for handling the old JSON file.

Copilot AI review requested due to automatic review settings November 15, 2025 17:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR completes the migration from pypi_formula_mappings.json to the new pypi_packages DSL by removing all code related to the old JSON-based system.

Key changes:

  • Removed PypiPackages.from_json_file method and associated flags (needs_manual_update, defined_pypi_mapping)
  • Eliminated pypi_formula_mappings method and constant from Tap and CoreTap classes
  • Simplified formula initialization to use the new DSL exclusively

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Library/Homebrew/utils/pypi.rb Removed logic that checked and used JSON-based package mappings
Library/Homebrew/test/tap_spec.rb Removed test setup and assertions for pypi_formula_mappings
Library/Homebrew/test/spec_helper.rb Removed cleanup reference to pypi_formula_mappings.json file
Library/Homebrew/test/pypi_packages_spec.rb Deleted entire test file that tested JSON file parsing
Library/Homebrew/tap_auditor.rb Removed pypi_formula_mappings from auditor attributes and checks
Library/Homebrew/tap.rb Removed pypi_formula_mappings method, constant, and cache variable from both Tap and CoreTap classes
Library/Homebrew/pypi_packages.rb Removed from_json_file factory method and needs_manual_update/defined_pypi_mapping flags
Library/Homebrew/formula.rb Simplified PypiPackages initialization and removed needs_manual_update parameter from pypi_packages DSL

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Nov 16, 2025
Merged via the queue into main with commit caa7af5 Nov 16, 2025
56 of 57 checks passed
@MikeMcQuaid MikeMcQuaid deleted the rm-pypi-json-code branch November 16, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants