MNT/FIX: Generalize Lo resweep handling #2531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed by other data products too, so we can pull out the ancillary file handling to get the resweep values into a helper function. Change from for-loops and setting individual elements to numpy vectorization for resweeping. Fix exposure time calculation that was incorrectly assigning to many ESA levels during a sweep. We should only have 7 total values in the exposure factor calculation of esa_sweeps.
greglucas
added
Ins: Lo
greglucas
merged commit 7ee85a0
into
IMAP-Science-Operations-Center:dev
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Overview
This is needed by other data products too, so we can pull out the ancillary file handling to get the resweep values into a helper function.
Change from for-loops and setting individual elements to numpy vectorization for resweeping.
Fix exposure time calculation that was incorrectly assigning to many ESA levels during a sweep. We should only have 7 total values in the exposure factor calculation of esa_sweeps.