Conversation
Tom-Willemsen
left a comment
There was a problem hiding this comment.
I'll give this a more thorough functional test tomorrow...
src/howl.rs
Outdated
| fbb.finished_data() | ||
| } | ||
|
|
||
| #[allow(clippy::too_many_arguments)] |
There was a problem hiding this comment.
I know this is pretty much exactly how I'd written it in the python too, with a zillion arguments, but I think the more extensible approach is to pull all of the "howl config" arguments into a HowlConfig struct, instantiated once in main, and passed through as &HowlConfig to anywhere that needs it.
This avoids multiple methods all taking a similar huge list of arguments.
There was a problem hiding this comment.
do you think it'd make sense to have
A) one struct for the entire howl command's arguments
B) one struct for common args ie. an EventMessageConfig which is used from main -> howl -> produce_messages -> generate_fake_events? It seems inefficient to pass all of the args given to howl to every func down the chain?
There was a problem hiding this comment.
I was thinking both, but you could combine both approaches by including a EventMessageConfig within a HowlConfig struct
Co-authored-by: Tom Willemsen <tom.willemsen@stfc.ac.uk>
f32 does not have dynamic range for ms/ns since epoch
Convert saluki to rust.
Changes to note:
listenandconsumehave been merged, as they were quite similar anyway. README and--helpshould clarify how to useconsume(which is aliased tolistenfor muscle memory's sake!)playhas not been carried over as I ran out of time to be able to call this personal development. rewriteplayin rust #50 exists to add it when we need to use it again.howlis a bit faster than python, though I haven't tried the "cheat" way of only constructing one set of det values but sending them x times a frame.also note that the CI is currently failing at the time of writing but only because one of the apt mirrors seems to be 404ing?working nowI may also need a hand benchmarking
howlplz @Tom-Willemsen