Fix Spurious fires due to I2C Bus Contention#212
Merged
Conversation
|
FSM SILSIM: 6/6 passed ✓ — plots |
Contributor
Author
|
#213 related |
mpkarpov-ui
force-pushed
the
bugfix/pyro-i2c-contention
branch
from
73298cb to
410617d
Compare
mpkarpov-ui
changed the title
Contributor
Author
|
#213 fixed |
This was referenced May 5, 2026
MuhammadAli8209
approved these changes
May 7, 2026
Contributor
MuhammadAli8209
left a comment
MuhammadAli8209
left a comment
There was a problem hiding this comment.
I see, so far from what I can tell: updating pyro states jailed in mutex, as well as gps. ADC revamp does look much nicer cus it takes out a bunch of repetitive stuff. LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds i2c mutex + reduces contention by caching gpio expander states
TODO: Fix contention because of ADC