fix(elements): strip Blazor externalObject from expression tree events - master#17251
Open
IMinchev64 wants to merge 1 commit intomasterfrom
Open
fix(elements): strip Blazor externalObject from expression tree events - master#17251IMinchev64 wants to merge 1 commit intomasterfrom
IMinchev64 wants to merge 1 commit intomasterfrom
Conversation
IMinchev64
added
❌ status: awaiting-test
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a Blazor interoperability issue where externalObject injected into filtering/expression trees breaks serialization/comparison logic when those trees are used as event payloads.
Changes:
- Ignores
externalObjectduring Query Builder tree comparison to prevent unnecessary UI re-creation. - Strips
externalObjectfrom expression/filtering tree payloads for specific Elements output events.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| projects/igniteui-angular/query-builder/src/query-builder/query-builder-tree.component.ts | Updates the JSON stringify replacer ignore-list to skip externalObject during expression group comparisons. |
| projects/igniteui-angular-elements/src/app/custom-strategy.ts | Adds handling for expression-tree-related outputs to remove externalObject from emitted event args. |
IMinchev64
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/Infragistics-Developer-Tools/dev-tools/issues/3208
Description
Motivation / Context
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
How Has This Been Tested?
Test Configuration:
Screenshots / Recordings
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)