fix(elements): strip Blazor externalObject from expression tree events - 20.1.x#17253
Open
IMinchev64 wants to merge 2 commits into20.1.xfrom
Open
fix(elements): strip Blazor externalObject from expression tree events - 20.1.x#17253IMinchev64 wants to merge 2 commits into20.1.xfrom
IMinchev64 wants to merge 2 commits into20.1.xfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses Blazor-injected externalObject values leaking into expression-tree-related event payloads, which can break comparison/serialization scenarios in Ignite UI Angular and the Elements strategy layer (issue #3208).
Changes:
- Ignore
externalObjectduring Query Builder tree equality checks to prevent unnecessary root recreation / stringify failures. - Strip
externalObjectfrom expression-tree-related output event args in the Angular Elements custom strategy.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| projects/igniteui-angular/src/lib/query-builder/query-builder-tree.component.ts | Adds externalObject to the JSON stringify replacer ignore list used for root group comparison. |
| projects/igniteui-angular-elements/src/app/custom-strategy.ts | Adds expression-tree event handling that removes condition.externalObject from emitted trees before dispatching events. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/Infragistics-Developer-Tools/dev-tools/issues/3208
Description
Motivation / Context
Type of Change (check all that apply):
Component(s) / Area(s) Affected:
How Has This Been Tested?
Test Configuration:
Screenshots / Recordings
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)