Shock application (PiShock & OpenShock)#11
Open
stevenjwheeler wants to merge 26 commits into
Open
Conversation
…shock and pishock)
stevenjwheeler
changed the title
Author
Added PiShock! This PR was originally just OpenShock directly, but now there is a ShockManager interface that deals with retrieving shockers from the enabled platforms and issuing commands to the revelant client to use their API. |
Owner
|
@stevenjwheeler whoa, I didn't get a notification about this, or it went to spam! This is cool |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull is for a fully functional Shock application, allowing users to control their own and shared OpenShock and PiShock devices via the Yip-Boi interface.
It adds a new screen to the Yip-Boi with controls for:
This PR also adds the new ShockManager interface, allowing the system to talk with multiple modular shock backends, which means that the Yip-Boi itself doesn't care about what platform the device is on and the ShockManager deals with the API calls. It also means that any future platforms can be added relatively easily.
It also adds a menu to the YipOS application for entering the API keys, seeing the statuses, testing the connection and setting custom intensity and duration increments, along with a safety warning.
The macro atlas was regenerated for the new screen, so will likely require an update to the unity asset.
Tested with my own OpenShock account and device.