-
Notifications
You must be signed in to change notification settings - Fork 32
Fix DLPack С-contiguous stride reconstruction #2219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/2219/index.html |
|
Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_77 ran successfully. |
ndgrigorian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
those are the only comments from me, everything else LGTM
|
Array API standard conformance tests for dpctl=0.22.0dev0=py310h93fe807_94 ran successfully. |
Previously
C-contiguousarrays withndim > 0were exported withNULLstrides while F-contiguous strides were computed explicitly.In #2193
NULLstrides are no longer allowed due to DLPack v 1.2 and missing strides started to becomputed using only
F-orderlogic so C-contiguous arrays were exported with incorrect stridesThis PR adds stride computation for C-contiguous layouts and resolves #2213