feat(ci): report nightly test history to tcache - #3624
Draft
OlufemiAdeOlusile wants to merge 3 commits into
Draft
Conversation
Add a report-history flag and a new "Report nightly history" step to the reusable regression workflow, PUTting each failed nightly run's JUnit XML to tcache's separate /history endpoint. Gated on report-history rather than the existing testrun_name input so manual regression/regression-dbsync dispatches never write here. Wire testrun_name and report-history: true into the three real nightly workflows (nightly, nightly-cli, nightly-dbsync).
Expose report-history on regression.yaml's manual dispatch and widen the history-upload gate to success-or-failure, so a quick smoke-test dispatch actually exercises the new curl call against real tcache without waiting on a real failure or running the full nightly suite. TEMPORARY - to be reverted before this PR is finalized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Nightly runs never report anything to tcache today (none of the three
nightly workflows set
testrun_name). This wires them up to a new,separate
/historyendpoint on tcache (merged inmkoura/testing-results-cache#14), so the failure-analysis step can later
tell a new failure from one that happened last night too.
report-historyinput + "Report nightly history" step inregression_reusable.yaml, PUTting to/history/<testrun_name>/<job_id>on failure. Separate from the existing
/importstep (a differentroute, a different table on tcache's side).
report-history, not justtestrun_name, so manualregression/regression-dbsyncdispatches never write to/history-only the three nightly workflows opt in.
nightly.yaml/nightly_cli.yaml/nightly_dbsync.yamlnow settestrun_name(nightly/nightly-cli/nightly-dbsync) andreport-history: true.Side effect worth knowing: setting
testrun_nameon the nightlies for thefirst time also turns on the pre-existing
/importstep for them (it waspreviously dormant since they never set
testrun_name). Sinceskip_passedstays off, that data is written but never read back - nofunctional change, just extra rows/files on tcache's existing side.
Follow-up, not in this PR: feeding the downloaded history into the
failure-analysis prompt (Phase 3).
Test plan
./ai_run.sh make lint- clean except the pre-existing,unrelated
debug-statementsfailure (reproduces onmastertoo).the new step actually PUTs to tcache's
/historyendpoint.