Skip to content

PR for #42 enable estimation using fixest#57

Open
zhizhongpu wants to merge 55 commits intomainfrom
42-enable-estimation-using-fixest
Open

PR for #42 enable estimation using fixest#57
zhizhongpu wants to merge 55 commits intomainfrom
42-enable-estimation-using-fixest

Conversation

@zhizhongpu
Copy link
Collaborator

Roadmap: #42 (comment)

@zhizhongpu zhizhongpu linked an issue Oct 3, 2025 that may be closed by this pull request
@zhizhongpu zhizhongpu removed the request for review from santiagohermo October 3, 2025 18:56
@zhizhongpu
Copy link
Collaborator Author

@santiagohermo the goal of this issue has been achieved so I'm opening this PR. I'm following the road map in #42 (comment).

The next step is to converge on the following:

  1. how we'd like to organize the new functionality with respect to the existing.
  2. package defaults and future plans on lm_robust vs fixest
  3. what tests we'd need to build (and perhaps the magnitude of the tolerance)
  4. future modifications to the package (e.g. the discussions on S3 here Enable estimation using -fixest- #42 (comment))

and then I can complete the housekeeping items (including writing documentations and making the GitHub Action tests pass) and you can review.


I think it's most efficient if we discuss live. I've emailed to arrange a meeting. Prior to the meeting it'd be great if you could skim the changes to have a sense of roughly what changed / got added.

@santiagohermo
Copy link
Collaborator

Thanks for the great work @zhizhongpu! I agree, discussing live seems more efficient. I'll go over the updates and comments before our conversation.

@zhizhongpu
Copy link
Collaborator Author

NTS: everything else in #57 (comment) is done except for 3.

Will work on 3 next week and then address reviewer comments, then housekeeping / documentations

Copy link
Collaborator Author

@zhizhongpu zhizhongpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two to-do items about fixest SEs differing too much from STATA

@zhizhongpu
Copy link
Collaborator Author

@santiagohermo

so I think it's time for you to take a look.

@zhizhongpu
Copy link
Collaborator Author

@santiagohermo there's no rush but just sending a regular reminder.

1 similar comment
@zhizhongpu
Copy link
Collaborator Author

@santiagohermo there's no rush but just sending a regular reminder.

@zhizhongpu
Copy link
Collaborator Author

@santiagohermo there's no rush but just sending a regular reminder.

also fyi I'm leaving JMS Lab in the upcoming months so I'd be great to have this PR resolved before my formal departure, although it's not strictly necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable estimation using -fixest-

3 participants