Skip to content

fix: reflect request origin in CORS responses instead of wildcard #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mkitti wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: reflect request origin in CORS responses instead of wildcard #375

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions fileglancer/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,11 +460,15 @@ def mask_password(url: str) -> str:

app.add_middleware(
CORSMiddleware,
allow_origins=["*"],
# Use allow_origin_regex instead of allow_origins=["*"] so Starlette
# reflects the specific request origin rather than returning "*".
# This is required because allow_credentials=True + "Access-Control-Allow-Origin: *"
# causes browsers to block responses even for non-credentialed requests.
allow_origin_regex=r".*",
allow_credentials=True,
allow_methods=["GET","HEAD","POST","PUT","PATCH","DELETE"],
allow_headers=["*"],
expose_headers=["Range", "Content-Range"],
expose_headers=["Range", "Content-Range", "Accept-Ranges", "Content-Length"],
)


Expand Down
Loading