fix: drop optional flagged params set to an empty string in build_command#399
Open
allison-truhlar wants to merge 2 commits into
Open
fix: drop optional flagged params set to an empty string in build_command#399allison-truhlar wants to merge 2 commits into
allison-truhlar wants to merge 2 commits into
Conversation
…mand - this fixes the case where a runnables.yaml sets a default value for an optional flagged parameter to "", or where a payload to the API includes a value of "" for a flagged parameter. Note - the UI does not allow for empty strings to be submitted, so this is a purely backend fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was motivated by a Tensorswitch job failing when an optional flagged parameter was passed a default value "" from the runnables.yaml. This fixes the case where a runnables.yaml sets a default value for an optional flagged parameter to "", or where a payload to the API includes a value of "" for a flagged parameter. Note - the UI does not allow for empty strings to be submitted, so this is a purely backend fix.