Skip TinyTeX download and PDF test in CI #415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JessicaTegner
force-pushed
the
jessica/tinytex_fix
branch
2 times, most recently
from
2018a21 to
bd7409b
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
This PR is being reviewed by Cursor Bugbot
Details
Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
JessicaTegner
force-pushed
the
jessica/tinytex_fix
branch
2 times, most recently
from
487e89c to
35b94de
Compare
JessicaTegner
force-pushed
the
jessica/tinytex_fix
branch
from
35b94de to
5c8da9a
Compare
JessicaTegner
force-pushed
the
jessica/tinytex_fix
branch
2 times, most recently
from
977cdb2 to
2150072
Compare
JessicaTegner
force-pushed
the
jessica/tinytex_fix
branch
from
2150072 to
9f830b3
Compare
.github/workflows/ci.yaml
Outdated
| python3 -c "import pytinytex; pytinytex.download_tinytex()" | ||
| echo "Adding TinyTeX to PATH" | ||
| TINYTEX_PATH=$(python3 -c "import pytinytex; print(pytinytex.get_tinytex_path())") | ||
| echo "$TINYTEX_PATH" >> $GITHUB_PATH |
There was a problem hiding this comment.
Bug: Unnecessary TinyTeX Install in CI
The workflow installs TinyTeX in CI, but the only test that requires it (test_pdf_conversion) is skipped when CI == "true". Since GitHub Actions automatically sets CI=true, the PDF test never runs in CI, making the TinyTeX installation step wasteful and unnecessary. Either the TinyTeX installation should be removed, or the test skip condition needs adjustment.
JessicaTegner
changed the title
JessicaTegner
force-pushed
the
jessica/tinytex_fix
branch
from
d31d77b to
1999a28
Compare
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Stops installing TinyTeX in CI and skips the PDF conversion test when running in CI.
setup-tinytexsteps from/.github/workflows/ci.yaml.@unittest.skipIf(os.environ.get("CI") == "true")totest_pdf_conversionintests.pyto skip PDF conversion in CI.Written by Cursor Bugbot for commit 1999a28. This will update automatically on new commits. Configure here.