Handle malformed language tags and ensure fallback to en-001#3241
Merged
Conversation
Oleksandr Karpovich (eymar)
requested a review
from Shagen Ogandzhanian (Schahen)
July 20, 2026 10:17
| // Used when the browser reports no usable preferred language, so that Locale.current always | ||
| // returns at least one locale as required by PlatformLocaleDelegate's contract. | ||
| // The locale code en-001 denotes the English language spoken in the World. | ||
| private const val FALLBACK_LANGUAGE_TAG = "en-001" |
There was a problem hiding this comment.
This is going to be a stupid question but I have to ask - is it per spec? Can we be sure that this fallback value won't throw Exception in some browser?
Member
Author
There was a problem hiding this comment.
yes. en-001 conforms the BCP-47 spec. 001 means "World", not country-specific.
https://www.localeplanet.com/icu/en-001/index.html
Shagen Ogandzhanian (Schahen)
self-requested a review
July 21, 2026 11:17
Shagen Ogandzhanian (Schahen)
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes https://youtrack.jetbrains.com/issue/CMP-10359
Testing
Release Notes
Fixes - Web