Update shadow jar plugin, and code cleanup#5246
Update shadow jar plugin, and code cleanup#5246Omico wants to merge 6 commits intoJetBrains:masterfrom
Conversation
gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/ComposePlugin.kt
Outdated
Show resolved
Hide resolved
…L and correct license url
Test.systemProperties() marked as EXTENSION_SHADOWED_BY_MEMBER
Since ComposeBuildConfig.composeVersion is a static Sting and its parent is an object class we don't need to use get or lazy.
MatkovIvan
left a comment
There was a problem hiding this comment.
Combining cleanups and introducing new public API is not good idea.
PS I've assigned right people as reviewers
gradle-plugins/compose/src/main/kotlin/org/jetbrains/compose/ComposePlugin.kt
Outdated
Show resolved
Hide resolved
|
Could you explain your motivation for refactorings and version updates? |
Just general code cleanup, I can revert it if you unhappy with that. For our current
Also, the code above is generable via Kotlinpoet, but I don't have time to implement it because I have a full-time job. |





Please review each commit message for the details.