Conversation
…al state (with additional versification step) to minimize problems with dependent tasks. "preparePluginForSigning" renamed to "preparePluginInternalsForSigning"
ikopylov
force-pushed
the
update-for-gradle-build-script-for-plugin-singing
branch
from
e676a21 to
94d4d07
Compare
smolchanovsky
approved these changes
Mar 17, 2026
ForNeVeR
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build script update:
buildPlugintask was rolled back to its original state to minimize problems with dependent tasks. Additional verification step added tobuildPlugin.preparePluginForSigningrenamed topreparePluginInternalsForSigningintellij-platform-gradle-pluginprovides tasks for signing the archive itself and for publishing. And these tasks are strictly depends on originalbuildPlugintask. Previous implementation of the build script reimplemented thebuildPlugintask, which will result in errors if someone decides to use the publishing task. My attempts to unwire tasks led to a large amount of hard to support code, that's why it is better to keep original version ofbuildPlugin. This approach was implemented for EzArgs plugin ( JetBrains/EzArgs#50 ) and for EnhancedUnrealEngineDocumentation ( JetBrains/EnhancedUnrealEngineDocumentation#30 ). It make sense to port these changes to this plugin too