Switch Excel support to XLSX.jl#439
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #439 +/- ##
==========================================
- Coverage 91.17% 91.09% -0.08%
==========================================
Files 11 11
Lines 714 719 +5
==========================================
+ Hits 651 655 +4
- Misses 63 64 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Had to add magic bytes as well as extensions to get over ambiguity with NPZ. |
|
As with #124, "There is a bit of a chicken and egg situation here": the tests in I've put the |
|
Yeah, I also haven't found a patented solution for this... |
|
I've tested on my own fork, so I know tests pass. I just don't want to tag a release until I know what version of FileIO will eventually work. In my So it is just a question of knowing the version to use in the condition. I can tag a release as soon as I know this for certain. |
I will need to make a new release of XLSX.jl for this, but would prefer to know the version of FileIO.jl needed for compats. XLSX.jl is ready to go - you can inspect it here if you wish.
Will resolve #428.