add option to change subsolver in AL#310
Merged
dpo merged 2 commits intoJuliaSmoothOptimizers:masterfrom Apr 24, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for selecting which subproblem solver the Augmented Lagrangian (AL) algorithm uses, and expands tests to cover running AL with different subsolvers.
Changes:
- Add a
subsolverkeyword pathway for equality-constrained AL runs (and update the AL docstring example accordingly). - Update
ALSolverconstruction to accept a configurablesubsolver. - Extend
test_AL.jlto exercise AL withR2SolverandR2NSolver.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/AL_alg.jl |
Introduces configurable AL subsolver selection and updates the public docstring/example. |
test/test_AL.jl |
Adds regression coverage for selecting AL subsolvers (R2Solver, R2NSolver). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #310 +/- ##
===========================================
+ Coverage 61.53% 83.85% +22.31%
===========================================
Files 11 12 +1
Lines 1292 1641 +349
===========================================
+ Hits 795 1376 +581
+ Misses 497 265 -232 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MaxenceGollier
commented
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.