Skip to content

add option to change subsolver in AL#310

Merged
dpo merged 2 commits intoJuliaSmoothOptimizers:masterfrom
MaxenceGollier:al-subsolver
Apr 24, 2026
Merged

add option to change subsolver in AL#310
dpo merged 2 commits intoJuliaSmoothOptimizers:masterfrom
MaxenceGollier:al-subsolver

Conversation

@MaxenceGollier
Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI review requested due to automatic review settings March 9, 2026 17:25
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for selecting which subproblem solver the Augmented Lagrangian (AL) algorithm uses, and expands tests to cover running AL with different subsolvers.

Changes:

  • Add a subsolver keyword pathway for equality-constrained AL runs (and update the AL docstring example accordingly).
  • Update ALSolver construction to accept a configurable subsolver.
  • Extend test_AL.jl to exercise AL with R2Solver and R2NSolver.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/AL_alg.jl Introduces configurable AL subsolver selection and updates the public docstring/example.
test/test_AL.jl Adds regression coverage for selecting AL subsolvers (R2Solver, R2NSolver).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/AL_alg.jl
Comment thread src/AL_alg.jl
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.85%. Comparing base (e0f214d) to head (fe2b13c).
⚠️ Report is 281 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master     #310       +/-   ##
===========================================
+ Coverage   61.53%   83.85%   +22.31%     
===========================================
  Files          11       12        +1     
  Lines        1292     1641      +349     
===========================================
+ Hits          795     1376      +581     
+ Misses        497      265      -232     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/AL_alg.jl Outdated
Copy link
Copy Markdown
Member

@dpo dpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@dpo dpo merged commit 337245a into JuliaSmoothOptimizers:master Apr 24, 2026
14 checks passed
@MaxenceGollier MaxenceGollier deleted the al-subsolver branch April 24, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants